Bug 208989

Summary: [WebXR] Import wpt tests
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988    
Attachments:
Description Flags
Patch youennf: review+

Sergio Villar Senin
Reported 2020-03-12 03:39:29 PDT
[WebXR] Import wpt tests
Attachments
Patch (326.32 KB, patch)
2020-03-12 03:42 PDT, Sergio Villar Senin 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-03-12 03:42:45 PDT
Created attachment 393356 [details] Patch
youenn fablet
Comment 2 2020-03-13 02:28:56 PDT
Comment on attachment 393356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393356&action=review > LayoutTests/TestExpectations:4144 > +webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/xrWebGLLayer_viewports.https.html [ Skip ] Maybe simply skip the whole folder?
Sergio Villar Senin
Comment 3 2020-03-16 07:06:12 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 393356 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393356&action=review > > > LayoutTests/TestExpectations:4144 > > +webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/xrWebGLLayer_viewports.https.html [ Skip ] > > Maybe simply skip the whole folder? The reason why I'm listing then individually is because I'm planning to unskip them one by one as I implement the APIs. I think it was possible to skip a whole folder and then mark individual tests as passing, but as I saw none in TestExpectations I decided to do it this way...
Sergio Villar Senin
Comment 4 2020-03-16 09:04:06 PDT
(In reply to Sergio Villar Senin from comment #3) > (In reply to youenn fablet from comment #2) > > Comment on attachment 393356 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=393356&action=review > > > > > LayoutTests/TestExpectations:4144 > > > +webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/xrWebGLLayer_viewports.https.html [ Skip ] > > > > Maybe simply skip the whole folder? > > The reason why I'm listing then individually is because I'm planning to > unskip them one by one as I implement the APIs. I think it was possible to > skip a whole folder and then mark individual tests as passing, but as I saw > none in TestExpectations I decided to do it this way... There are examples of this in platform specific TestExpectations so I think I'll change it. Thanks for the suggestion
Sergio Villar Senin
Comment 5 2020-03-16 09:09:59 PDT
Committed r258499: <https://trac.webkit.org/changeset/258499>
Radar WebKit Bug Importer
Comment 6 2020-03-16 09:10:16 PDT
<rdar://problem/60496729>
Note You need to log in before you can comment on or make changes to this bug.