Bug 208964

Summary: [Curl] sort out MS vs Seconds confusion in Cookies
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: WebCore Misc.Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, chris.reid, commit-queue, don.olmstead, ews-watchlist, fujii.hironori, galpeter, takashi.komori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Windows 10   
Attachments:
Description Flags
Patch none

Pavel Feldman
Reported 2020-03-11 17:49:53 PDT
Cookie parser is currently putting seconds into Cookies::expires instead of milliseconds. Fixing it and using consistent time methods around the changed code.
Attachments
Patch (7.57 KB, patch)
2020-03-11 17:53 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2020-03-11 17:53:42 PDT
Created attachment 393318 [details] Patch
Pavel Feldman
Comment 2 2020-03-11 17:56:34 PDT
- It all started in parseCookieAttributes where seconds instead of millis were put into cookies.expires. - Then searchCookies was multiplying it by 1000 on fetch from DB. - Additionally datetime('now') is returning 2020 for me, so I'm moving it to the wall time comparison.
WebKit Commit Bot
Comment 3 2020-03-12 07:09:46 PDT
Comment on attachment 393318 [details] Patch Clearing flags on attachment: 393318 Committed r258325: <https://trac.webkit.org/changeset/258325>
WebKit Commit Bot
Comment 4 2020-03-12 07:09:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-03-12 07:10:16 PDT
<rdar://problem/60369754>
Note You need to log in before you can comment on or make changes to this bug.