Bug 208951

Summary: Adopt AVSampleBufferVideoOutput
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jer Noble
Reported 2020-03-11 15:55:31 PDT
Adopt AVSampleBufferVideoOutput
Attachments
Patch (9.80 KB, patch)
2020-03-11 15:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.83 KB, patch)
2020-03-11 16:22 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-03-11 15:59:30 PDT
<rdar://problem/31763425>
Jer Noble
Comment 2 2020-03-11 15:59:59 PDT
Created attachment 393298 [details] Patch
Eric Carlson
Comment 3 2020-03-11 16:03:10 PDT
Comment on attachment 393298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393298&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:772 > + m_videoOutput = adoptNS([PAL::allocAVSampleBufferVideoOutputInstance() init]); Nit: it might be worth adding an ASSERT here
Jer Noble
Comment 4 2020-03-11 16:22:34 PDT
Created attachment 393303 [details] Patch for landing
WebKit Commit Bot
Comment 5 2020-03-11 21:57:35 PDT
Comment on attachment 393303 [details] Patch for landing Clearing flags on attachment: 393303 Committed r258314: <https://trac.webkit.org/changeset/258314>
WebKit Commit Bot
Comment 6 2020-03-11 21:57:37 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 7 2020-03-16 17:30:57 PDT
http://trac.webkit.org/r258533
Note You need to log in before you can comment on or make changes to this bug.