Bug 208949

Summary: Add a parameter to allow ignoring app-bound domain categorization
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, cdumez, commit-queue, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 209842    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Kate Cheney
Reported 2020-03-11 15:19:55 PDT
In some cases we would like a way to avoid setting parameters based on app-bound domain navigation. We should have a way to do this.
Attachments
Patch (5.87 KB, patch)
2020-03-11 15:25 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.88 KB, patch)
2020-03-11 15:51 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.88 KB, patch)
2020-03-11 16:05 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2020-03-11 15:20:13 PDT
<rdar://problem/60239187>
Kate Cheney
Comment 2 2020-03-11 15:25:23 PDT
Created attachment 393294 [details] Patch
Brent Fulgham
Comment 3 2020-03-11 15:27:44 PDT
Comment on attachment 393294 [details] Patch r=me
Chris Dumez
Comment 4 2020-03-11 15:36:54 PDT
Comment on attachment 393294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393294&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:1218 > +- (void)_setIgnoreAppBoundDomains:(BOOL)shouldIgnoreAppBoundDomains I don't this the naming is right here. I think it should either: _ignoresAppBoundDomains / _setIgnoresAppBoundDomains or _shouldIgnoreAppBoundDomains / _setShouldIgnoreAppBoundDomains
Kate Cheney
Comment 5 2020-03-11 15:51:15 PDT
Created attachment 393297 [details] Patch for landing
Kate Cheney
Comment 6 2020-03-11 15:51:54 PDT
(In reply to katherine_cheney from comment #5) > Created attachment 393297 [details] > Patch for landing missed one.
Kate Cheney
Comment 7 2020-03-11 16:05:20 PDT
Created attachment 393300 [details] Patch for landing
WebKit Commit Bot
Comment 8 2020-03-11 16:54:04 PDT
Comment on attachment 393300 [details] Patch for landing Clearing flags on attachment: 393300 Committed r258296: <https://trac.webkit.org/changeset/258296>
WebKit Commit Bot
Comment 9 2020-03-11 16:54:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-03-11 16:55:14 PDT
<rdar://problem/60348017>
Note You need to log in before you can comment on or make changes to this bug.