Summary: | Add a parameter to allow ignoring app-bound domain categorization | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||||
Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, beidson, bfulgham, cdumez, commit-queue, ggaren, thorton, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 209842 | ||||||||||
Attachments: |
|
Description
Kate Cheney
2020-03-11 15:19:55 PDT
Created attachment 393294 [details]
Patch
Comment on attachment 393294 [details]
Patch
r=me
Comment on attachment 393294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393294&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:1218 > +- (void)_setIgnoreAppBoundDomains:(BOOL)shouldIgnoreAppBoundDomains I don't this the naming is right here. I think it should either: _ignoresAppBoundDomains / _setIgnoresAppBoundDomains or _shouldIgnoreAppBoundDomains / _setShouldIgnoreAppBoundDomains Created attachment 393297 [details]
Patch for landing
(In reply to katherine_cheney from comment #5) > Created attachment 393297 [details] > Patch for landing missed one. Created attachment 393300 [details]
Patch for landing
Comment on attachment 393300 [details] Patch for landing Clearing flags on attachment: 393300 Committed r258296: <https://trac.webkit.org/changeset/258296> All reviewed patches have been landed. Closing bug. |