Bug 208935

Summary:

Remove TextTrackPrivateRemote.messages.in

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, commit-queue, don.olmstead, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Eric Carlson

Reported 2020-03-11 12:23:33 PDT

Remove TextTrackPrivateRemote.messages.in, it isn't needed.

Attachments
Patch (6.55 KB, patch) 2020-03-11 13:09 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing (7.26 KB, patch) 2020-03-11 13:24 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing (8.41 KB, patch) 2020-03-11 15:23 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing (9.54 KB, patch) 2020-03-12 06:57 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2020-03-11 13:09:19 PDT

Created attachment 393280 [details] Patch

Radar WebKit Bug Importer

Comment 2 2020-03-11 13:10:05 PDT

<rdar://problem/60337433>

Don Olmstead

Comment 3 2020-03-11 13:12:17 PDT

r=me but you're going to need to remove the file reference from Source/WebKit/CMakeLists.txt to get GTK and WPE to come back green

Eric Carlson

Comment 4 2020-03-11 13:24:20 PDT

Created attachment 393282 [details] Patch for landing

WebKit Commit Bot

Comment 5 2020-03-11 14:36:22 PDT

Comment on attachment 393282 [details] Patch for landing Rejecting attachment 393282 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: WebKit.build/Release/Derived\ Sources.build/Script-C0CE72841247E66800BC0EC4.sh\" Generating message receiver for AuthenticationManager... Generating message receiver for AuxiliaryProcess... Generating message receiver for CacheStorageEngineConnection... Generating message receiver for DownloadProxy... Generating message receiver for DrawingArea... Generating message receiver for DrawingAreaProxy... Generating message receiver for EditableImageController... Generating message receiver for EventDispatcher... Generating message receiver for GPUProcess... Generating message receiver for GPUProcessProxy... Generating message receiver for GPUProcessConnection... Generating message receiver for GPUConnectionToWebProcess... Generating message receiver for LegacyCustomProtocolManager... Generating message receiver for LegacyCustomProtocolManagerProxy... Generating message receiver for LibWebRTCCodecs... Generating message receiver for LibWebRTCCodecsProxy... Generating message receiver for MediaPlayerPrivateRemote... Generating message receiver for NPObjectMessageReceiver... Generating message receiver for NetworkConnectionToWebProcess... Generating message receiver for NetworkContentRuleListManager... Generating message receiver for NetworkMDNSRegister... Generating message receiver for NetworkProcess... Generating message receiver for NetworkProcessConnection... Generating message receiver for NetworkProcessProxy... Generating message receiver for NetworkRTCMonitor... Generating message receiver for NetworkRTCProvider... Generating message receiver for NetworkRTCSocket... Generating message receiver for NetworkResourceLoader... Generating message receiver for NetworkSocketChannel... Generating message receiver for NetworkSocketStream... Generating message receiver for PlaybackSessionManager... Generating message receiver for PlaybackSessionManagerProxy... Generating message receiver for PluginControllerProxy... Generating message receiver for PluginProcess... Generating message receiver for PluginProcessConnection... Generating message receiver for PluginProcessConnectionManager... Generating message receiver for PluginProcessProxy... Generating message receiver for PluginProxy... Generating message receiver for RemoteAudioDestinationManager... Generating message receiver for RemoteAudioDestinationProxy... Generating message receiver for RemoteAudioSession... Generating message receiver for RemoteAudioSessionProxy... Generating message receiver for RemoteAudioMediaStreamTrackRendererManager... Generating message receiver for RemoteAudioMediaStreamTrackRenderer... Generating message receiver for RemoteLayerTreeDrawingAreaProxy... Generating message receiver for RemoteCDMProxy... Generating message receiver for RemoteCDMFactoryProxy... Generating message receiver for RemoteCDMInstanceProxy... Generating message receiver for RemoteCDMInstanceSession... Generating message receiver for RemoteCDMInstanceSessionProxy... Generating message receiver for RemoteLegacyCDMProxy... Generating message receiver for RemoteLegacyCDMFactoryProxy... Generating message receiver for RemoteLegacyCDMSession... Generating message receiver for RemoteLegacyCDMSessionProxy... Generating message receiver for RemoteMediaPlayerManager... Generating message receiver for RemoteMediaPlayerManagerProxy... Generating message receiver for RemoteMediaPlayerProxy... Generating message receiver for RemoteMediaRecorder... Generating message receiver for RemoteMediaRecorderManager... Generating message receiver for RemoteMediaResourceManager... Generating message receiver for RemoteMediaSessionHelper... Generating message receiver for RemoteMediaSessionHelperProxy... Generating message receiver for RemoteObjectRegistry... Generating message receiver for RemoteRenderingBackend... Generating message receiver for RemoteRenderingBackendProxy... Generating message receiver for RemoteSampleBufferDisplayLayer... Generating message receiver for RemoteSampleBufferDisplayLayerManager... Generating message receiver for RemoteScrollingCoordinator... Generating message receiver for RemoteWebInspectorProxy... Generating message receiver for RemoteWebInspectorUI... Generating message receiver for SampleBufferDisplayLayer... Generating message receiver for SecItemShimProxy... Generating message receiver for ServiceWorkerFetchTask... Generating message receiver for SmartMagnificationController... Generating message receiver for StorageAreaMap... Generating message receiver for StorageManagerSet... make: *** No rule to make target `TextTrackPrivateRemoteMessageReceiver.cpp', needed by `all'. Stop. make: *** Waiting for unfinished jobs.... Generating message receiver for TextCheckingControllerProxy... Command /bin/sh failed with exit code 2 ** BUILD FAILED ** The following build commands failed: PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/Derived\ Sources.build/Script-C0CE72841247E66800BC0EC4.sh (1 failure) Full output: https://webkit-queues.webkit.org/results/13338842

Eric Carlson

Comment 6 2020-03-11 15:23:27 PDT

Created attachment 393293 [details] Patch for landing

Eric Carlson

Comment 7 2020-03-12 06:57:15 PDT

Created attachment 393371 [details] Patch for landing

WebKit Commit Bot

Comment 8 2020-03-12 08:17:43 PDT

Comment on attachment 393371 [details] Patch for landing Clearing flags on attachment: 393371 Committed r258327: <https://trac.webkit.org/changeset/258327>

WebKit Commit Bot

Comment 9 2020-03-12 08:17:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.