Bug 208899

Summary: [GPU Process] Work towards compiling out on non-Cocoa ports
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit2Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, darin, dino, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, mmaxfield, philipj, ryuan.choi, sabouhallawa, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208814
Bug Depends on:    
Bug Blocks: 206697    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch
none
Patch
darin: review+
Patch none

Don Olmstead
Reported 2020-03-10 17:34:45 PDT
Currently only Apple can compile.
Attachments
WIP Patch (26.18 KB, patch)
2020-03-10 17:41 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (26.01 KB, patch)
2020-03-10 17:47 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (29.19 KB, patch)
2020-03-10 18:42 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (29.13 KB, patch)
2020-03-10 18:51 PDT, Don Olmstead 		darin: review+
DetailsFormatted DiffDiff
Patch (29.02 KB, patch)
2020-03-10 21:39 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-03-10 17:41:24 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-03-10 17:47:19 PDT
Created attachment 393193 [details] WIP Patch
Darin Adler
Comment 3 2020-03-10 18:05:25 PDT
Comment on attachment 393193 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393193&action=review > Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:39 > +#include <WebCore/GraphicsContext.h> This should just be added to unconditional includes above, rather than putting it here in the #else.
Don Olmstead
Comment 4 2020-03-10 18:14:11 PDT
Comment on attachment 393193 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393193&action=review >> Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:39 >> +#include <WebCore/GraphicsContext.h> > > This should just be added to unconditional includes above, rather than putting it here in the #else. The GraphicsContextCG.h stuff was needed below. I actually had just WebCore/GraphicsContext.h in the previous patch but Apple builds failed.
Darin Adler
Comment 5 2020-03-10 18:21:33 PDT
Comment on attachment 393193 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393193&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:206 > +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)) It would be nice to have a simpler #if here, but maybe this exactly matches how the player code is if-def’d.
Don Olmstead
Comment 6 2020-03-10 18:42:55 PDT Comment hidden (obsolete)
Don Olmstead
Comment 7 2020-03-10 18:46:42 PDT
Comment on attachment 393193 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393193&action=review >> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:206 >> +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)) > > It would be nice to have a simpler #if here, but maybe this exactly matches how the player code is if-def’d. Yea it matches whats in that file.
Don Olmstead
Comment 8 2020-03-10 18:51:25 PDT
Created attachment 393200 [details] Patch Make style checker happy. Should be good to go.
Konstantin Tokarev
Comment 9 2020-03-10 19:11:52 PDT
Aren't you clashing with work done in https://bugs.webkit.org/show_bug.cgi?id=208814 ?
Don Olmstead
Comment 10 2020-03-10 19:17:25 PDT
(In reply to Konstantin Tokarev from comment #9) > Aren't you clashing with work done in > https://bugs.webkit.org/show_bug.cgi?id=208814 ? Sure but this compiles and is a bit simpler.
Darin Adler
Comment 11 2020-03-10 20:51:38 PDT
Comment on attachment 393200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393200&action=review > Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:39 > +#include <WebCore/GraphicsContext.h> I still think this include should be unconditional in the paragraph above rather than having it inside an #else.
Don Olmstead
Comment 12 2020-03-10 21:39:43 PDT
Created attachment 393204 [details] Patch Patch for landing
WebKit Commit Bot
Comment 13 2020-03-10 22:44:54 PDT
Comment on attachment 393204 [details] Patch Clearing flags on attachment: 393204 Committed r258253: <https://trac.webkit.org/changeset/258253>
WebKit Commit Bot
Comment 14 2020-03-10 22:44:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2020-03-10 22:45:13 PDT
<rdar://problem/60308681>
Note You need to log in before you can comment on or make changes to this bug.