Bug 208880

Summary:

FocusController::setFocusedElement() should tell client of refocused element

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=147836

Attachments:

Description	Flags
Patch	none
Patch	none

Daniel Bates

Reported 2020-03-10 13:19:14 PDT

FocusController::setFocusedElement() should tell the client when an element that is already focused is being asked to become focused again. This allows a client to re-evaluate whether to provide UI assistance to an element (e.g. bring up the keyboard on iOS).

Attachments
Patch (4.71 KB, patch) 2020-03-10 14:04 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (4.72 KB, patch) 2020-03-10 14:10 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2020-03-10 14:04:00 PDT

Created attachment 393176 [details] Patch

Daniel Bates

Comment 2 2020-03-10 14:10:01 PDT

Created attachment 393177 [details] Patch

Daniel Bates

Comment 3 2020-03-10 14:12:12 PDT

<rdar://problem/58870777>

Wenson Hsieh

Comment 4 2020-03-11 18:36:59 PDT

Comment on attachment 393177 [details] Patch Seems reasonable to me. What effect (if any) does this have on Speedometer?

Daniel Bates

Comment 5 2020-03-12 09:18:02 PDT

(In reply to Wenson Hsieh from comment #4) > Comment on attachment 393177 [details] > Patch > > Seems reasonable to me. What effect (if any) does this have on Speedometer? It has no effect on Speedometer: the branch is never hit.

Daniel Bates

Comment 6 2020-03-12 09:18:10 PDT

Thanks for the review.

Daniel Bates

Comment 7 2020-03-12 09:19:24 PDT

Comment on attachment 393177 [details] Patch Clearing flags on attachment: 393177 Committed r258333: <https://trac.webkit.org/changeset/258333>

Daniel Bates

Comment 8 2020-03-12 09:19:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.