Bug 20887 – Legend tag should be exposed through AX

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

the object in AX representing the field set should have its title ui element set to the legend tag (if there is a legend tag)

[chris fleizach]

Created attachment 23548 [details]
Expose <legend> tag in AX

[Darin Adler]

Comment on attachment 23548 [details]
Expose <legend> tag in AX

 427     Node *element = m_renderer->element();

Should be Node*, not "Node *".

 1061     if (isFieldset())
 1062         return axObjectCache()->get(static_cast<RenderFieldset*>(m_renderer)->findLegend());

This assumes that the renderer will be a RenderFieldset because the tag is fieldsetTag. Why is that a safe assumption? Instead, both function should be looking at hte renderer, and neither should be asking what the tag name is.

Patch otherwise looks fine. review- because of the DOM/Renderer assumption.

[chris fleizach]

Created attachment 23566 [details]
<legend> patch, updated based on review

[Darin Adler]

Comment on attachment 23566 [details]
<legend> patch, updated based on review

     virtual bool isWidget() const { return false; }
-
+    virtual bool isFieldset() const { return false; }

The rest of these are in alphabetical order. It would be better if you sorted your new one in rather than putting it at the bottom.

r=me

[chris fleizach]

http://trac.webkit.org/changeset/36670