Bug 208847

Summary:

[CMake] Sync feature defines in XCode projects

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, cgarcia, commit-queue, ews-watchlist, glenn, gyuyoung.kim, jbedard, krollin, mcatanzaro, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	annulen: review+
Patch	none

Don Olmstead

Reported 2020-03-09 19:34:44 PDT

There are a few things missing from them.

Attachments
Patch (5.93 KB, patch) 2020-03-09 19:36 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (34.09 KB, patch) 2020-03-09 20:01 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (34.09 KB, patch) 2020-03-09 20:02 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (9.30 KB, patch) 2020-03-09 20:02 PDT, Don Olmstead	annulen: review+	Details Formatted Diff Diff
Patch (5.92 KB, patch) 2020-03-09 20:13 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2020-03-09 19:36:31 PDT

Created attachment 393110 [details] Patch

Konstantin Tokarev

Comment 2 2020-03-09 19:51:33 PDT

Comment on attachment 393110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393110&action=review > Source/cmake/WebKitFeatures.cmake:99 > + WEBKIT_OPTION_DEFINE(ENABLE_APPLE_PAY_SESSION_V9 "Toggle Apple Pay Session V9 support" PRIVATE OFF) FWIW, it would be better to move options specific to Mac port to OptionsMac.cmake (I assume that ApplePay is not used in AppleWin or any other port, as well as some other options added in this patch) > Source/cmake/WebKitFeatures.cmake:141 > + WEBKIT_OPTION_DEFINE(ENABLE_GPU_PROCESS "Toggle GPU Process support" PRIVATE ON) Shouldn't it be OFF by default?

Don Olmstead

Comment 3 2020-03-09 20:00:57 PDT

Comment on attachment 393110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393110&action=review >> Source/cmake/WebKitFeatures.cmake:99 >> + WEBKIT_OPTION_DEFINE(ENABLE_APPLE_PAY_SESSION_V9 "Toggle Apple Pay Session V9 support" PRIVATE OFF) > > FWIW, it would be better to move options specific to Mac port to OptionsMac.cmake (I assume that ApplePay is not used in AppleWin or any other port, as well as some other options added in this patch) They aren't but I want to generate the FeatureList.pm and the whole Mac CMake needs a clean up in general so I'd like to sidestep that for the moment. >> Source/cmake/WebKitFeatures.cmake:141 >> + WEBKIT_OPTION_DEFINE(ENABLE_GPU_PROCESS "Toggle GPU Process support" PRIVATE ON) > > Shouldn't it be OFF by default? Copy pasta error. Fixing now.

Don Olmstead

Comment 4 2020-03-09 20:01:19 PDT Comment hidden (obsolete)

Created attachment 393112 [details] Patch

Don Olmstead

Comment 5 2020-03-09 20:02:02 PDT Comment hidden (obsolete)

Created attachment 393113 [details] Patch

Don Olmstead

Comment 6 2020-03-09 20:02:40 PDT Comment hidden (obsolete)

Created attachment 393114 [details] Patch

Don Olmstead

Comment 7 2020-03-09 20:13:21 PDT

Created attachment 393116 [details] Patch