Bug 208838

Summary: Build Fix
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Megan Gardner
Reported 2020-03-09 15:24:50 PDT
Build Fix
Attachments
Patch (3.71 KB, patch)
2020-03-09 15:25 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.70 KB, patch)
2020-03-09 17:31 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.94 KB, patch)
2020-03-09 18:08 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-03-09 15:25:44 PDT
Created attachment 393085 [details] Patch
Darin Adler
Comment 2 2020-03-09 15:30:13 PDT
Comment on attachment 393085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393085&action=review > Source/WTF/wtf/PlatformHave.h:609 > +#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) I think you mean PLATFORM(IOS) here. Please read Tim Horton’s internal Apple mail, subject "An important note about version checks!"
Megan Gardner
Comment 3 2020-03-09 17:31:30 PDT
Created attachment 393098 [details] Patch
Darin Adler
Comment 4 2020-03-09 17:35:34 PDT
Comment on attachment 393098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393098&action=review Looks fine to me. > Source/WTF/wtf/PlatformHave.h:609 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) Don’t need the parentheses here.
Megan Gardner
Comment 5 2020-03-09 18:08:15 PDT
Created attachment 393102 [details] Patch
WebKit Commit Bot
Comment 6 2020-03-09 21:04:11 PDT
Comment on attachment 393102 [details] Patch Clearing flags on attachment: 393102 Committed r258183: <https://trac.webkit.org/changeset/258183>
WebKit Commit Bot
Comment 7 2020-03-09 21:04:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-03-09 21:05:15 PDT
<rdar://problem/60258638>
Note You need to log in before you can comment on or make changes to this bug.