Bug 208838

Summary: Build Fix
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Megan Gardner 2020-03-09 15:24:50 PDT 
Build Fix
Comment 1 Megan Gardner 2020-03-09 15:25:44 PDT 
Created attachment 393085 [details]
Patch
Comment 2 Darin Adler 2020-03-09 15:30:13 PDT 
Comment on attachment 393085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393085&action=review

> Source/WTF/wtf/PlatformHave.h:609
> +#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)

I think you mean PLATFORM(IOS) here.

Please read Tim Horton’s internal Apple mail, subject "An important note about version checks!"
Comment 3 Megan Gardner 2020-03-09 17:31:30 PDT 
Created attachment 393098 [details]
Patch
Comment 4 Darin Adler 2020-03-09 17:35:34 PDT 
Comment on attachment 393098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393098&action=review

Looks fine to me.

> Source/WTF/wtf/PlatformHave.h:609
> +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)

Don’t need the parentheses here.
Comment 5 Megan Gardner 2020-03-09 18:08:15 PDT 
Created attachment 393102 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-09 21:04:11 PDT 
Comment on attachment 393102 [details]
Patch

Clearing flags on attachment: 393102

Committed r258183: <https://trac.webkit.org/changeset/258183>
Comment 7 WebKit Commit Bot 2020-03-09 21:04:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-09 21:05:15 PDT 
<rdar://problem/60258638>