Bug 20882

Summary:

Don't do a call when you want to do a return – unless you really, really have to.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
The patch	ggaren: review+

Description Gavin Barraclough 2008-09-16 09:26:25 PDT

Code generation for op_ret, calls can be inlined unless there is an activation, a profiler, or the codeblock needsFullScopeChain & the scope chain needs derefing.

+1.5% SS, +5/6% v8-tests

Comment 1 Gavin Barraclough 2008-09-16 09:56:43 PDT

Created attachment 23476 [details]
The patch

Comment 2 Geoffrey Garen 2008-09-16 10:05:02 PDT

Comment on attachment 23476 [details]
The patch

r=me

Comment 3 Gavin Barraclough 2008-09-16 10:40:59 PDT

Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/VM/CTI.cpp
Sending        JavaScriptCore/VM/CTI.h
Sending        JavaScriptCore/VM/Machine.cpp
Sending        JavaScriptCore/VM/Machine.h
Transmitting file data .....
Committed revision 36514.