Bug 208801

Summary: Fix WPT test redirect-mode.any.html
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Rob Buis 2020-03-09 02:11:33 PDT
Fix WPT test redirect-mode.any.html by also specifying the server port, this
is needed for WebKit local test runs.
Comment 1 Rob Buis 2020-03-09 02:15:25 PDT
Created attachment 393017 [details]
Patch
Comment 2 youenn fablet 2020-03-09 03:27:35 PDT
Comment on attachment 393017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393017&action=review

> LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode.any.js:9
> +    url.port = get_host_info().HTTP_PORT;

Is the URL only HTTP? Should we consider HTTPS_PORT as well?
Comment 3 Rob Buis 2020-03-09 03:44:50 PDT
Created attachment 393020 [details]
Patch
Comment 4 Rob Buis 2020-03-09 07:30:51 PDT
Comment on attachment 393017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393017&action=review

>> LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode.any.js:9
>> +    url.port = get_host_info().HTTP_PORT;
> 
> Is the URL only HTTP? Should we consider HTTPS_PORT as well?

I think for https it would have needed the https extension in the file name. BTW Anne reviewed so I'll land this soon, not sure when it will get updated on wpt.fyi.
Comment 5 WebKit Commit Bot 2020-03-09 08:45:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 393020 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 160571 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-03-09 08:46:05 PDT
Comment on attachment 393020 [details]
Patch

Clearing flags on attachment: 393020

Committed r258144: <https://trac.webkit.org/changeset/258144>
Comment 7 WebKit Commit Bot 2020-03-09 08:46:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-09 08:47:18 PDT
<rdar://problem/60224557>