Summary: | Fix WPT test redirect-mode.any.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||
Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari Technology Preview | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Rob Buis
2020-03-09 02:11:33 PDT
Created attachment 393017 [details]
Patch
Comment on attachment 393017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393017&action=review > LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode.any.js:9 > + url.port = get_host_info().HTTP_PORT; Is the URL only HTTP? Should we consider HTTPS_PORT as well? Created attachment 393020 [details]
Patch
Comment on attachment 393017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393017&action=review >> LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode.any.js:9 >> + url.port = get_host_info().HTTP_PORT; > > Is the URL only HTTP? Should we consider HTTPS_PORT as well? I think for https it would have needed the https extension in the file name. BTW Anne reviewed so I'll land this soon, not sure when it will get updated on wpt.fyi. The commit-queue encountered the following flaky tests while processing attachment 393020 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 160571 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 393020 [details] Patch Clearing flags on attachment: 393020 Committed r258144: <https://trac.webkit.org/changeset/258144> All reviewed patches have been landed. Closing bug. |