Bug 208797

Summary: Make TextIterator::range return a SimpleRange
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, achristensen, andersca, apinheiro, cdumez, cfleizach, dmazzoni, don.olmstead, esprehn+autocc, ews-watchlist, jcraig, jdiggs, kangil.han, mifenton, samuel_white, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch don.olmstead: review+

Darin Adler
Reported 2020-03-08 22:19:57 PDT
Make TextIterator::range return a SimpleRange
Attachments
Patch (35.39 KB, patch)
2020-03-08 22:35 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (41.79 KB, patch)
2020-03-08 23:34 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (40.49 KB, patch)
2020-03-09 20:12 PDT, Darin Adler 		don.olmstead: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-03-08 22:35:37 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2020-03-08 22:36:21 PDT
Trying to go slow on the deployment of SimpleRange. Easy for a refactoring patch to get out of hand and get too big to review.
Darin Adler
Comment 3 2020-03-08 23:34:05 PDT Comment hidden (obsolete)
Darin Adler
Comment 4 2020-03-09 20:12:41 PDT
Created attachment 393115 [details] Patch
Darin Adler
Comment 5 2020-03-09 21:03:10 PDT
Looks like the tests are passing so it’s ready for review now.
Darin Adler
Comment 6 2020-03-10 21:07:26 PDT
Committed r258250: <https://trac.webkit.org/changeset/258250>
Radar WebKit Bug Importer
Comment 7 2020-03-10 21:08:16 PDT
<rdar://problem/60306553>
Note You need to log in before you can comment on or make changes to this bug.