Bug 208785

Summary: Remember completed subranges during incremental PDF loading
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, thorton, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
PFL
none
PFL none

Brady Eidson
Reported 2020-03-08 10:06:30 PDT
Remember completed subranges during incremental PDF loading We'll often get asked for the same range twice, or for range contained in previously requested ranges. To make that (orders of magnitude) more efficient, we should remember which ranges in the PDF buffer have previously been requested.
Attachments
Patch (7.64 KB, patch)
2020-03-08 15:44 PDT, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
PFL (7.79 KB, patch)
2020-03-08 16:07 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
PFL (7.79 KB, patch)
2020-03-08 16:24 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2020-03-08 15:44:02 PDT
Created attachment 392995 [details] Patch
Brady Eidson
Comment 2 2020-03-08 15:52:09 PDT
This relies on the patch in https://bugs.webkit.org/show_bug.cgi?id=208790 landing first (hence lots of failures)
Brady Eidson
Comment 3 2020-03-08 16:07:24 PDT
Created attachment 392996 [details] PFL
Brady Eidson
Comment 4 2020-03-08 16:24:33 PDT
Created attachment 392998 [details] PFL
WebKit Commit Bot
Comment 5 2020-03-08 17:42:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 392998 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 160571 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-03-08 17:43:33 PDT
Comment on attachment 392998 [details] PFL Clearing flags on attachment: 392998 Committed r258123: <https://trac.webkit.org/changeset/258123>
WebKit Commit Bot
Comment 7 2020-03-08 17:43:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-03-08 17:44:15 PDT
<rdar://problem/60207010>
Note You need to log in before you can comment on or make changes to this bug.