Bug 20876

Summary: REGRESSION (r36417, r36427): fast/js/exception-expression-offset.html fails
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Cameron Zwarich (cpst) <zwarich>
Status: RESOLVED FIXED    
Severity: Normal CC: mjs, sam
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch for 'instanceof' case
none
Proposed patch for 'instanceof' case
oliver: review-
Proposed patch mjs: review+

Cameron Zwarich (cpst)
Reported 2008-09-15 22:08:29 PDT
Recent changes to op_instanceof and op_construct in r36417 and r36427 mean that exception data is not correctly emitted for op_instanceof and op_construct. An op_get_by_id is emitted to get the prototype property ahead of time, but there is no exception data for these new opcodes. This shouldn't be too hard to fix: just make these opcodes use ThrowableSubExpressionData and emit the right information.
Attachments
Proposed patch for 'instanceof' case (1.27 KB, patch)
2008-09-17 20:59 PDT, Cameron Zwarich (cpst) 		no flags
DetailsFormatted DiffDiff
Proposed patch for 'instanceof' case (5.18 KB, patch)
2008-09-17 21:00 PDT, Cameron Zwarich (cpst) 		oliver: review-
DetailsFormatted DiffDiff
Proposed patch (9.55 KB, patch)
2008-09-17 22:54 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-09-17 20:59:50 PDT
Created attachment 23519 [details] Proposed patch for 'instanceof' case Here's a patch for the 'instanceof' case. The constructor case requires actual subexpression data, but I should be able to do it easily after figuring out this case.
Cameron Zwarich (cpst)
Comment 2 2008-09-17 21:00:36 PDT
Created attachment 23520 [details] Proposed patch for 'instanceof' case Oops. Here is the version with the layout test changes as well.
Oliver Hunt
Comment 3 2008-09-17 21:07:43 PDT
Comment on attachment 23520 [details] Proposed patch for 'instanceof' case r- as this reduces the fidelity of the error messages, and the error range no longer covers the entire instanceof
Cameron Zwarich (cpst)
Comment 4 2008-09-17 22:54:35 PDT
Created attachment 23521 [details] Proposed patch This patch fixes both cases, and it does not change any of the exception information at all.
Maciej Stachowiak
Comment 5 2008-09-17 23:16:36 PDT
Comment on attachment 23521 [details] Proposed patch r=me
Cameron Zwarich (cpst)
Comment 6 2008-09-17 23:22:08 PDT
Landed in r36604.
Note You need to log in before you can comment on or make changes to this bug.