Bug 208732

Summary: [GPUP] Enable Picture-in-Picture support on Mac
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: New BugsAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Peng Liu 2020-03-06 13:09:03 PST 
[GPUP] Enable Picture-in-Picture support on Mac
Comment 1 Peng Liu 2020-03-06 13:15:04 PST 
Created attachment 392763 [details]
Patch
Comment 2 Eric Carlson 2020-03-06 13:18:45 PST 
Comment on attachment 392763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392763&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:683
> +    m_cachedState.hasVideo = m_player->hasVideo();

Oops!
Comment 3 Radar WebKit Bug Importer 2020-03-06 13:54:25 PST 
<rdar://problem/60169440>
Comment 4 WebKit Commit Bot 2020-03-06 14:13:34 PST 
Comment on attachment 392763 [details]
Patch

Clearing flags on attachment: 392763

Committed r258029: <https://trac.webkit.org/changeset/258029>
Comment 5 WebKit Commit Bot 2020-03-06 14:13:35 PST 
All reviewed patches have been landed.  Closing bug.