Bug 20858

Summary: make each distinct C++ class get a distinct JSC::Structure
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore JavaScriptAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ggaren, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
work in progress
none
patch 1
none
patch
none
work in progress
none
patch mjs: review+

Darin Adler
Reported 2008-09-15 09:38:41 PDT
This will allow us to move everything from virtual functions to functions based on things stored in Structure. Some of this work is in JavaScriptCore, but the hard part of it is in WebCore.
Attachments
work in progress (77.49 KB, patch)
2008-09-15 09:39 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch 1 (80.07 KB, patch)
2008-09-18 23:19 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (73.52 KB, patch)
2008-09-19 12:47 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
work in progress (32.65 KB, patch)
2008-09-19 17:50 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (131.88 KB, patch)
2008-09-20 14:33 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-09-15 09:39:47 PDT
Created attachment 23443 [details] work in progress
Darin Adler
Comment 2 2008-09-18 23:19:45 PDT
Created attachment 23555 [details] patch 1
Maciej Stachowiak
Comment 3 2008-09-18 23:44:31 PDT
Comment on attachment 23555 [details] patch 1 r=me
Darin Adler
Comment 4 2008-09-18 23:49:52 PDT
Comment on attachment 23555 [details] patch 1 Clearing the review flag since this part is landed now. http://trac.webkit.org/changeset/36662
Darin Adler
Comment 5 2008-09-19 12:47:57 PDT
Created attachment 23578 [details] patch
Darin Adler
Comment 6 2008-09-19 14:16:23 PDT
Comment on attachment 23578 [details] patch Clearing the review flag since this part is landed now. http://trac.webkit.org/changeset/36675
Darin Adler
Comment 7 2008-09-19 17:50:08 PDT
Created attachment 23587 [details] work in progress
Darin Adler
Comment 8 2008-09-20 13:53:37 PDT
Comment on attachment 23587 [details] work in progress Got a patch working now. Just running WebKit tests to make sure it doesn't break anything.
Darin Adler
Comment 9 2008-09-20 14:33:28 PDT
Created attachment 23613 [details] patch Passes all tests.
Darin Adler
Comment 10 2008-09-20 14:34:02 PDT
This patch takes care of all the rest! Once I land it, the task is done.
Maciej Stachowiak
Comment 11 2008-09-20 19:01:22 PDT
Comment on attachment 23613 [details] patch r=me Excellent work.
Note You need to log in before you can comment on or make changes to this bug.