Bug 20858

Summary: make each distinct C++ class get a distinct JSC::Structure
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore JavaScriptAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ggaren, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Macintosh   
OS: OS X 10.5   
Attachments:
Description Flags
work in progress
none
patch 1
none
patch
none
work in progress
none
patch mjs: review+

Description Darin Adler 2008-09-15 09:38:41 PDT
This will allow us to move everything from virtual functions to functions based on things stored in Structure.

Some of this work is in JavaScriptCore, but the hard part of it is in WebCore.
Comment 1 Darin Adler 2008-09-15 09:39:47 PDT
Created attachment 23443 [details]
work in progress
Comment 2 Darin Adler 2008-09-18 23:19:45 PDT
Created attachment 23555 [details]
patch 1
Comment 3 Maciej Stachowiak 2008-09-18 23:44:31 PDT
Comment on attachment 23555 [details]
patch 1

r=me
Comment 4 Darin Adler 2008-09-18 23:49:52 PDT
Comment on attachment 23555 [details]
patch 1

Clearing the review flag since this part is landed now.

http://trac.webkit.org/changeset/36662
Comment 5 Darin Adler 2008-09-19 12:47:57 PDT
Created attachment 23578 [details]
patch
Comment 6 Darin Adler 2008-09-19 14:16:23 PDT
Comment on attachment 23578 [details]
patch

Clearing the review flag since this part is landed now.

http://trac.webkit.org/changeset/36675
Comment 7 Darin Adler 2008-09-19 17:50:08 PDT
Created attachment 23587 [details]
work in progress
Comment 8 Darin Adler 2008-09-20 13:53:37 PDT
Comment on attachment 23587 [details]
work in progress

Got a patch working now. Just running WebKit tests to make sure it doesn't break anything.
Comment 9 Darin Adler 2008-09-20 14:33:28 PDT
Created attachment 23613 [details]
patch

Passes all tests.
Comment 10 Darin Adler 2008-09-20 14:34:02 PDT
This patch takes care of all the rest! Once I land it, the task is done.
Comment 11 Maciej Stachowiak 2008-09-20 19:01:22 PDT
Comment on attachment 23613 [details]
patch

r=me

Excellent work.