Bug 208572 – [GStreamer][GL] External OES textures rendering support

• Component: Platform
• Status: RESOLVED FIXED

[Philippe Normand]

.

[Philippe Normand]

Created attachment 392412 [details]
Patch

[Philippe Normand]

Checking GTK build.

[Xabier Rodríguez Calvar]

Comment on attachment 392412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392412&action=review

This looks good from the GStreamer perspective but maybe some other people with more graphics proficiency could have another look.

> Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:235
> -    gst_pad_add_probe(pad.get(), static_cast<GstPadProbeType>(GST_PAD_PROBE_TYPE_PUSH | GST_PAD_PROBE_TYPE_QUERY_DOWNSTREAM | GST_PAD_PROBE_TYPE_EVENT_FLUSH), [] (GstPad*, GstPadProbeInfo* info,  gpointer userData) -> GstPadProbeReturn {
> +    gst_pad_add_probe(pad.get(), static_cast<GstPadProbeType>(GST_PAD_PROBE_TYPE_PUSH | GST_PAD_PROBE_TYPE_QUERY_DOWNSTREAM | GST_PAD_PROBE_TYPE_EVENT_FLUSH), [] (GstPad* pad, GstPadProbeInfo* info,  gpointer userData) -> GstPadProbeReturn {
> +

These change seems to be unnecessary.

[Philippe Normand]

Comment on attachment 392412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392412&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:173
> +    GLSL_DIRECTIVE(extension GL_OES_EGL_image_external : require)

This and the sampler declaration break GTK at runtime. The shader seems to fail to compile but no error is reported.

[Philippe Normand]

Created attachment 392430 [details]
Patch

[Philippe Normand]

Created attachment 392431 [details]
Patch

[Zan Dobersek]

Comment on attachment 392431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392431&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:331
> -            return makeUnique<Buffer>(Buffer::TextureVariant { Buffer::RGBTexture { *static_cast<GLuint*>(m_videoFrame.data[0]) } }, m_size, m_flags, GL_RGBA);
> +            return makeUnique<Buffer>(Buffer::TextureVariant { Buffer::RGBTexture { m_textureID } }, m_size, m_flags, GL_RGBA);

For a separate patch: we could maybe drop m_textureID in favor of using m_videoFrame.data directly.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:394
> +    GstGLTextureTarget m_textureTarget;

This could be default-initialized to `GST_GL_TEXTURE_TARGET_NONE`.

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:178
> +    OES_EGL_IMAGE_EXTERNAL_DIRECTIVE

I think this directive should be written only if the program options demand it.

[Philippe Normand]

Created attachment 392553 [details]
Patch

[Zan Dobersek]

Comment on attachment 392553 [details]
Patch

LGTM.

[Philippe Normand]

Committed r258197: <https://trac.webkit.org/changeset/258197>

[Radar WebKit Bug Importer]

<rdar://problem/60269338>