Bug 208561

Summary: Move WKTextSelectionRect into its own file
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 13   
Bug Depends on:    
Bug Blocks: 208563    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Bates
Reported 2020-03-03 22:58:29 PST
Move WKTextSelectionRect into its own file.
Attachments
Patch (14.40 KB, patch)
2020-03-03 23:00 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (14.40 KB, patch)
2020-03-03 23:01 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (14.40 KB, patch)
2020-03-03 23:12 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-03-03 23:00:55 PST
Created attachment 392375 [details] Patch
Daniel Bates
Comment 2 2020-03-03 23:01:44 PST
Created attachment 392376 [details] Patch
Daniel Bates
Comment 3 2020-03-03 23:12:02 PST
Created attachment 392378 [details] Patch
Alex Christensen
Comment 4 2020-03-04 08:47:49 PST
Comment on attachment 392378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392378&action=review > Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm:32 > +#import <WebKit/WebSelectionRect.h> Do we still need this in WKContentViewInteraction.mm?
Daniel Bates
Comment 5 2020-03-04 09:54:16 PST
(In reply to Alex Christensen from comment #4) > Comment on attachment 392378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392378&action=review > > > Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm:32 > > +#import <WebKit/WebSelectionRect.h> > > Do we still need this in WKContentViewInteraction.mm? Yes for webSelectionRectsForSelectionRects(), but I sooo wanted to remove it. I was very tempted to move webSelectionRectsForSelectionRects() out of it to do so, but I decided to do a smaller step just to make it easy to a review.
Daniel Bates
Comment 6 2020-03-04 09:54:34 PST
Thanks for the review.
Daniel Bates
Comment 7 2020-03-04 10:04:09 PST
Comment on attachment 392378 [details] Patch Clearing flags on attachment: 392378 Committed r257851: <https://trac.webkit.org/changeset/257851>
Daniel Bates
Comment 8 2020-03-04 10:04:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-03-04 10:05:17 PST
<rdar://problem/60044325>
Note You need to log in before you can comment on or make changes to this bug.