Bug 208529

Summary:

Rename urlSelected to changeLocation

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

New Bugs

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, dbarton, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, gyuyoung.kim, japhet, pdr, sabouhallawa, schenney, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Rob Buis

Reported 2020-03-03 12:29:55 PST

Rename urlSelected to changeLocation and remove the existing changeLocation. The name changeLocation is more intuitive than urlSelected.

Attachments
Patch (16.73 KB, patch) 2020-03-03 12:32 PST, Rob Buis	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2020-03-03 12:32:54 PST

Created attachment 392310 [details] Patch

Darin Adler

Comment 2 2020-03-09 00:14:59 PDT

Comment on attachment 392310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392310&action=review > Source/WebCore/loader/FrameLoader.h:-132 > - void changeLocation(FrameLoadRequest&&); Was this just unused? I don’t see any cases of this in the patch.

Rob Buis

Comment 3 2020-03-09 01:29:43 PDT

Comment on attachment 392310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392310&action=review >> Source/WebCore/loader/FrameLoader.h:-132 >> - void changeLocation(FrameLoadRequest&&); > > Was this just unused? I don’t see any cases of this in the patch. It was used in a few places but those places can just use one of the old urlSelected overloads (now renamed to changeLocation), since I made the second parameter gain a default value. The old changeLocation was just filling in the second parameter and was not so useful.

Rob Buis

Comment 4 2020-03-09 01:32:13 PDT

Darin, I just noticed Source/WebCore/WebCore.order still mentions urlSelected. How important is it to keep this file in sync and is this done regularly? Willing to make a follow up patch if needed.

WebKit Commit Bot

Comment 5 2020-03-09 08:10:08 PDT

Comment on attachment 392310 [details] Patch Clearing flags on attachment: 392310 Committed r258140: <https://trac.webkit.org/changeset/258140>

WebKit Commit Bot

Comment 6 2020-03-09 08:10:10 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2020-03-09 08:11:15 PDT

<rdar://problem/60223618>

Darin Adler

Comment 8 2020-03-09 10:02:52 PDT

(In reply to Rob Buis from comment #4) > Darin, I just noticed Source/WebCore/WebCore.order still mentions > urlSelected. How important is it to keep this file in sync and is this done > regularly? Willing to make a follow up patch if needed. Not important at all. I don’t know why those order files are still checked in; there may be a good reason. But no matter what that reason is, they definitely can’t be correctly updated by editing the files by hand.

Note You need to log in before you can comment on or make changes to this bug.