Bug 208506

Summary:

REGRESSION(r257726): [GTK] LayoutTests crashing after r257726

Product:

WebKit

Reporter:

Diego Pino <dpino>

Component:

New Bugs

Assignee:

Diego Pino <dpino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cgarcia, commit-queue, Hironori.Fujii, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Diego Pino 2020-03-03 02:08:54 PST

[GTK] Unreviewed, remove unnecessary code which made LayoutTests crash

Comment 1 Diego Pino 2020-03-03 02:28:39 PST

Created attachment 392256 [details]
Patch

Comment 2 Diego Pino 2020-03-03 04:15:13 PST

Created attachment 392260 [details]
Patch

Comment 3 WebKit Commit Bot 2020-03-03 05:16:41 PST

Comment on attachment 392260 [details]
Patch

Clearing flags on attachment: 392260

Committed r257772: <https://trac.webkit.org/changeset/257772>

Comment 4 WebKit Commit Bot 2020-03-03 05:16:43 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2020-03-03 05:17:19 PST

<rdar://problem/59992464>

Comment 6 Fujii Hironori 2020-03-24 13:34:51 PDT

Comment on attachment 392260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392260&action=review

> Tools/WebKitTestRunner/TestController.cpp:-3102
> -    WKWebsiteDataStoreSetResourceLoadStatisticsEnabled(websiteDataStore(), true);

WKWebsiteDataStoreSetResourceLoadStatisticsEnabled seems needed for WinCairo port because it enables RESOURCE_LOAD_STATISTICS. I'm going to fix it in Bug 209410.