Bug 208504

Summary:

Avoid full style resolution on Element::focus()

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cdumez, cfleizach, cmarcelo, commit-queue, dmazzoni, emilio, esprehn+autocc, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, kangil.han, mifenton, rniwa, samuel_white, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220580

Attachments:

Description	Flags
wip	none
wip	none
wip	none
wip	none
patch	none
patch	zalan: review+
patch	none
patch	none
patch	none
followup	none
patch	none
followup	none

Antti Koivisto

Reported 2020-03-03 01:24:17 PST

It can be costly.

Attachments
wip (6.27 KB, patch) 2020-03-03 01:25 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
wip (7.94 KB, patch) 2020-03-03 03:20 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
wip (10.95 KB, patch) 2020-03-03 06:33 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
wip (12.16 KB, patch) 2020-03-03 10:37 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (15.62 KB, patch) 2020-03-03 12:47 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (15.68 KB, patch) 2020-03-03 12:49 PST, Antti Koivisto	zalan: review+	Details Formatted Diff Diff
patch (16.61 KB, patch) 2020-03-04 00:29 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (21.52 KB, patch) 2020-03-04 01:22 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (22.77 KB, patch) 2020-03-04 02:25 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
followup (1.82 KB, patch) 2020-03-04 06:26 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (1.82 KB, patch) 2020-03-04 06:55 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
followup (1.85 KB, patch) 2020-03-04 07:05 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2020-03-03 01:25:48 PST

Created attachment 392254 [details] wip

Antti Koivisto

Comment 2 2020-03-03 03:20:12 PST

Created attachment 392258 [details] wip

Antti Koivisto

Comment 3 2020-03-03 06:33:20 PST

Created attachment 392270 [details] wip

Antti Koivisto

Comment 4 2020-03-03 10:37:00 PST

Created attachment 392295 [details] wip

Antti Koivisto

Comment 5 2020-03-03 12:47:50 PST

Created attachment 392312 [details] patch

Antti Koivisto

Comment 6 2020-03-03 12:49:27 PST

Created attachment 392313 [details] patch

alan

Comment 7 2020-03-03 12:55:36 PST

Comment on attachment 392313 [details] patch I've got a bit of a compat/regression concern here, but let's see what happens...also YAY.

Ryosuke Niwa

Comment 8 2020-03-03 13:56:05 PST

Comment on attachment 392313 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=392313&action=review > Source/WebCore/ChangeLog:14 > + This appears to be 3-4% Speedometer progression. Nice!

Antti Koivisto

Comment 9 2020-03-04 00:29:15 PST

Created attachment 392385 [details] patch

Antti Koivisto

Comment 10 2020-03-04 01:22:10 PST

Created attachment 392393 [details] patch

Antti Koivisto

Comment 11 2020-03-04 02:25:36 PST

Created attachment 392399 [details] patch

WebKit Commit Bot

Comment 12 2020-03-04 04:11:19 PST

Comment on attachment 392399 [details] patch Clearing flags on attachment: 392399 Committed r257839: <https://trac.webkit.org/changeset/257839>

WebKit Commit Bot

Comment 13 2020-03-04 04:11:21 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 14 2020-03-04 04:12:18 PST

<rdar://problem/60035288>

Emilio Cobos Álvarez (:emilio)

Comment 15 2020-03-04 05:36:54 PST

Comment on attachment 392399 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=392399&action=review > Source/WebCore/dom/Element.cpp:3352 > + for (auto& element : ancestorsOfType<Element>(*this)) { This should probably be the flat / composed tree ancestors, right? I suspect this would crash otherwise in some shadow DOM situations involving slotting.

Antti Koivisto

Comment 16 2020-03-04 06:15:02 PST

Good point!

Antti Koivisto

Comment 17 2020-03-04 06:26:38 PST

Created attachment 392406 [details] followup

Antti Koivisto

Comment 18 2020-03-04 06:54:48 PST

Reopening for a followup

Antti Koivisto

Comment 19 2020-03-04 06:55:12 PST

Created attachment 392410 [details] patch

Antti Koivisto

Comment 20 2020-03-04 07:05:30 PST

Created attachment 392411 [details] followup

WebKit Commit Bot

Comment 21 2020-03-04 08:34:47 PST

Comment on attachment 392411 [details] followup Clearing flags on attachment: 392411 Committed r257846: <https://trac.webkit.org/changeset/257846>

WebKit Commit Bot

Comment 22 2020-03-04 08:34:49 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.