Bug 208432

Summary:

Begin moving off of live ranges for WebKit internals

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, annulen, apinheiro, cdumez, cfleizach, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jcraig, jdiggs, jer.noble, kangil.han, kondapallykalyan, mifenton, mmaxfield, pdr, ryuan.choi, samuel_white, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	dbates: review+

Darin Adler

Reported 2020-03-01 15:18:58 PST

Begin moving off of live ranges for WebKit internals, starting with TextIterator

Attachments
Patch (145.01 KB, patch) 2020-03-01 16:11 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (148.70 KB, patch) 2020-03-01 16:56 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (158.35 KB, patch) 2020-03-01 18:53 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (52.21 KB, patch) 2020-03-05 21:45 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (49.66 KB, patch) 2020-03-07 11:06 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (49.67 KB, patch) 2020-03-07 13:19 PST, Darin Adler	dbates: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2020-03-01 16:11:59 PST Comment hidden (obsolete)

Created attachment 392105 [details] Patch

Darin Adler

Comment 2 2020-03-01 16:56:12 PST Comment hidden (obsolete)

Created attachment 392110 [details] Patch

Darin Adler

Comment 3 2020-03-01 18:53:46 PST Comment hidden (obsolete)

Created attachment 392114 [details] Patch

Darin Adler

Comment 4 2020-03-05 21:45:24 PST Comment hidden (obsolete)

Created attachment 392676 [details] Patch

Darin Adler

Comment 5 2020-03-07 11:06:09 PST Comment hidden (obsolete)

Created attachment 392871 [details] Patch

Darin Adler

Comment 6 2020-03-07 13:19:00 PST

Created attachment 392882 [details] Patch

Daniel Bates

Comment 7 2020-03-08 08:55:52 PDT

Comment on attachment 392882 [details] Patch This patch looks good.

Darin Adler

Comment 8 2020-03-08 21:00:37 PDT

Committed r258129: <https://trac.webkit.org/changeset/258129>

Radar WebKit Bug Importer

Comment 9 2020-03-08 21:01:16 PDT

<rdar://problem/60210208>

Jer Noble

Comment 10 2020-03-09 06:58:03 PDT

Looks like this patch caused the following build error: https://build.webkit.org/builders/Apple-Catalina-Debug-Build/builds/4480/steps/compile-webkit/logs/errors /Volumes/Data/slave/catalina-debug/build/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:197:44: error: no matching constructor for initialization of 'WebCore::VisibleSelection' I'll try to see if I can come up with a fix, but if not, will do a roll-out.

Jer Noble

Comment 11 2020-03-09 07:01:46 PDT

(In reply to Jer Noble from comment #10) > Looks like this patch caused the following build error: > > https://build.webkit.org/builders/Apple-Catalina-Debug-Build/builds/4480/ > steps/compile-webkit/logs/errors > > /Volumes/Data/slave/catalina-debug/build/Source/WebKit/WebProcess/WebPage/ > Cocoa/WebPageCocoa.mm:197:44: error: no matching constructor for > initialization of 'WebCore::VisibleSelection' > > I'll try to see if I can come up with a fix, but if not, will do a roll-out. Looks like WebPageCocoa.mm was just missing a `#import <WebCore/SimpleRange.h>`. Will land a build fix.

Jer Noble

Comment 12 2020-03-09 07:05:11 PDT

Committed r258136: <http://trac.webkit.org/r258136>

Darin Adler

Comment 13 2020-03-09 09:58:50 PDT

Thanks Jer! I wonder how EWS missed that build failure.

Note You need to log in before you can comment on or make changes to this bug.