Bug 208432

Summary: Begin moving off of live ranges for WebKit internals
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, annulen, apinheiro, cdumez, cfleizach, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jcraig, jdiggs, jer.noble, kangil.han, kondapallykalyan, mifenton, mmaxfield, pdr, ryuan.choi, samuel_white, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch dbates: review+

Description Darin Adler 2020-03-01 15:18:58 PST 
Begin moving off of live ranges for WebKit internals, starting with TextIterator
Comment 1 Darin Adler 2020-03-01 16:11:59 PST Comment hidden (obsolete)
Comment 2 Darin Adler 2020-03-01 16:56:12 PST Comment hidden (obsolete)
Comment 3 Darin Adler 2020-03-01 18:53:46 PST Comment hidden (obsolete)
Comment 4 Darin Adler 2020-03-05 21:45:24 PST Comment hidden (obsolete)
Comment 5 Darin Adler 2020-03-07 11:06:09 PST Comment hidden (obsolete)
Comment 6 Darin Adler 2020-03-07 13:19:00 PST 
Created attachment 392882 [details]
Patch
Comment 7 Daniel Bates 2020-03-08 08:55:52 PDT 
Comment on attachment 392882 [details]
Patch

This patch looks good.
Comment 8 Darin Adler 2020-03-08 21:00:37 PDT 
Committed r258129: <https://trac.webkit.org/changeset/258129>
Comment 9 Radar WebKit Bug Importer 2020-03-08 21:01:16 PDT 
<rdar://problem/60210208>
Comment 10 Jer Noble 2020-03-09 06:58:03 PDT 
Looks like this patch caused the following build error:

https://build.webkit.org/builders/Apple-Catalina-Debug-Build/builds/4480/steps/compile-webkit/logs/errors

/Volumes/Data/slave/catalina-debug/build/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:197:44: error: no matching constructor for initialization of 'WebCore::VisibleSelection'

I'll try to see if I can come up with a fix, but if not, will do a roll-out.
Comment 11 Jer Noble 2020-03-09 07:01:46 PDT 
(In reply to Jer Noble from comment #10)
> Looks like this patch caused the following build error:
> 
> https://build.webkit.org/builders/Apple-Catalina-Debug-Build/builds/4480/
> steps/compile-webkit/logs/errors
> 
> /Volumes/Data/slave/catalina-debug/build/Source/WebKit/WebProcess/WebPage/
> Cocoa/WebPageCocoa.mm:197:44: error: no matching constructor for
> initialization of 'WebCore::VisibleSelection'
> 
> I'll try to see if I can come up with a fix, but if not, will do a roll-out.

Looks like WebPageCocoa.mm was just missing a `#import <WebCore/SimpleRange.h>`. Will land a build fix.
Comment 12 Jer Noble 2020-03-09 07:05:11 PDT 
Committed r258136: <http://trac.webkit.org/r258136>
Comment 13 Darin Adler 2020-03-09 09:58:50 PDT 
Thanks Jer!

I wonder how EWS missed that build failure.