Bug 208407

Summary:

[GTK] WebKit fails to build when Wayland target is disabled

Product:

WebKit

Reporter:

Ting-Wei Lan <lantw44>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bugs-noreply, cgarcia, commit-queue, darin, ews-watchlist, gustavo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ting-Wei Lan 2020-02-29 01:07:09 PST

Values in the enum WebCore::PlatformDisplay::Type are only defined when
their corresponding platform targets are enabled, so we need #if checks
around uses of them.

Please add this patch to webkit-2.28 branch if it is accepted.

Comment 1 Ting-Wei Lan 2020-02-29 01:08:45 PST

Created attachment 392052 [details]
Patch

Comment 2 EWS Watchlist 2020-02-29 01:09:36 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 WebKit Commit Bot 2020-03-01 19:20:48 PST

Comment on attachment 392052 [details]
Patch

Clearing flags on attachment: 392052

Committed r257700: <https://trac.webkit.org/changeset/257700>

Comment 4 WebKit Commit Bot 2020-03-01 19:20:50 PST

All reviewed patches have been landed.  Closing bug.