Bug 208398

Summary: Add new Mac target numbers
Product: WebKit Reporter: Alan Coon <alancoon.bugzilla>
Component: Tools / TestsAssignee: Alan Coon <alancoon>
Status: RESOLVED FIXED    
Severity: Normal CC: alancoon, ap, cdumez, commit-queue, dino, eric.carlson, ews-watchlist, graouts, jbedard, jberlin, keith_miller, kondapallykalyan, krollin, mark.lam, msaboff, repstein, rniwa, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alan Coon
Reported 2020-02-28 16:19:00 PST
Add new Mac target numbers.
Attachments
Patch (33.15 KB, patch)
2020-02-28 16:26 PST, Alan Coon 		no flags
DetailsFormatted DiffDiff
Patch (51.72 KB, patch)
2020-03-02 15:13 PST, Alan Coon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alan Coon
Comment 1 2020-02-28 16:26:25 PST
Created attachment 392032 [details] Patch
EWS Watchlist
Comment 2 2020-02-28 16:27:33 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Alexey Proskuryakov
Comment 3 2020-02-28 18:17:13 PST
Comment on attachment 392032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392032&action=review > Source/JavaScriptCore/ChangeLog:3 > + Add new Mac target numbers You are only updating xcconfigs in Source. Please update all projects, including those in Tools.
Alexey Proskuryakov
Comment 4 2020-02-29 09:12:48 PST
Please see r241990, r244714, r249312.
Alan Coon
Comment 5 2020-03-02 15:13:51 PST
Created attachment 392199 [details] Patch
Alexey Proskuryakov
Comment 6 2020-03-02 15:31:30 PST
Comment on attachment 392199 [details] Patch With some spot checking, this seems to cover all that we did last year. Did you chek if we had any new projects added since then?
Alan Coon
Comment 7 2020-03-02 16:19:18 PST
I checked with the following command, so we should be OK. grep -r -l --include \*.xcconfig 'TARGET_MAC_OS_X\|WK_MACOS_1014_YES\|WK_MACOS_BEFORE\|SYSTEM_VERSION_PREFIX_macosx\|MACOS_DEPLOYMENT_TARGET_macosx' . | sort -u
WebKit Commit Bot
Comment 8 2020-03-02 18:50:01 PST
Comment on attachment 392199 [details] Patch Clearing flags on attachment: 392199 Committed r257755: <https://trac.webkit.org/changeset/257755>
WebKit Commit Bot
Comment 9 2020-03-02 18:50:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-03-02 18:51:14 PST
<rdar://problem/59978992>
Note You need to log in before you can comment on or make changes to this bug.