Bug 208341

Summary: run-javascriptcore-tests: Make upload format valid
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-02-27 14:10:52 PST
A number of ports are having trouble uploading JSC results. We should print the json we attempted to upload when the upload fails.
Attachments
Patch (1016 bytes, patch)
2020-02-27 14:17 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.07 KB, patch)
2020-02-27 14:52 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.12 KB, patch)
2020-02-27 15:38 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2020-02-28 10:43 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.39 KB, patch)
2020-02-28 10:59 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-02-27 14:17:17 PST
Created attachment 391915 [details] Patch
Aakash Jain
Comment 2 2020-02-27 14:17:33 PST
(In reply to Jonathan Bedard from comment #0) > A number of ports are having trouble uploading JSC results. can you provide example? > We should print the json we attempted to upload when the upload fails. Wouldn't json be quite large? How will printing help? Is it for debugging?
Jonathan Bedard
Comment 3 2020-02-27 14:19:19 PST
(In reply to Aakash Jain from comment #2) > (In reply to Jonathan Bedard from comment #0) > > A number of ports are having trouble uploading JSC results. > can you provide example? > > > We should print the json we attempted to upload when the upload fails. > Wouldn't json be quite large? How will printing help? Is it for debugging? Not any larger than the log we've already printed. I sort of need this because I don't know why non Apple and Windows platforms are getting rejected by the server. I presume it's because their configurations are incorrect, but I don't know for sure.
Aakash Jain
Comment 4 2020-02-27 14:27:14 PST
(In reply to Jonathan Bedard from comment #3) > I sort of need this because I don't know why non Apple and Windows platforms are getting rejected by the server. I presume it's because their configurations are incorrect, but I don't know for sure. In that case, can you add a FIXME/TODO indicating that this is just for debugging and should be removed in some time.
Jonathan Bedard
Comment 5 2020-02-27 14:52:07 PST
Created attachment 391924 [details] Patch
Alexey Proskuryakov
Comment 6 2020-02-27 15:22:37 PST
Comment on attachment 391924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391924&action=review > Tools/Scripts/run-javascriptcore-tests:938 > + # FIXME: https://bugs.webkit.org/show_bug.cgi?id=208341 It's really hard to understand what this means even after looking at the bug. Can you change this to say something like "This is just for debugging and should be removed once not needed any more"? Even so, it's quite vague and non-actionable.
Jonathan Bedard
Comment 7 2020-02-27 15:38:31 PST
Created attachment 391934 [details] Patch
Aakash Jain
Comment 8 2020-02-27 15:42:52 PST
Comment on attachment 391934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391934&action=review > Tools/Scripts/run-javascriptcore-tests:938 > + # FIXME: This is for temporary debugging and should be removed https://bugs.webkit.org/show_bug.cgi?id=208341 looks better.
WebKit Commit Bot
Comment 9 2020-02-27 16:05:23 PST
Comment on attachment 391934 [details] Patch Clearing flags on attachment: 391934 Committed r257597: <https://trac.webkit.org/changeset/257597>
WebKit Commit Bot
Comment 10 2020-02-27 16:05:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-02-27 16:06:16 PST
<rdar://problem/59867155>
Jonathan Bedard
Comment 12 2020-02-28 07:58:40 PST
Found our problem: "version":"5.4.0-0"
Jonathan Bedard
Comment 13 2020-02-28 10:43:08 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 14 2020-02-28 10:43:09 PST
Created attachment 391993 [details] Patch
Aakash Jain
Comment 16 2020-02-28 10:46:30 PST
Comment on attachment 391993 [details] Patch rs=me
Jonathan Bedard
Comment 17 2020-02-28 10:59:11 PST
Created attachment 391998 [details] Patch for landing
WebKit Commit Bot
Comment 18 2020-02-28 11:31:36 PST
Comment on attachment 391998 [details] Patch for landing Clearing flags on attachment: 391998 Committed r257647: <https://trac.webkit.org/changeset/257647>
WebKit Commit Bot
Comment 19 2020-02-28 11:31:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.