Bug 208330

Summary: [Win] Fix AppleWin build
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Per Arne Vollan
Reported 2020-02-27 11:02:36 PST
CMake is giving an error: Imported target "WebKit::WTF" includes non-existent path .../Debug/build32/DerivedSources/ForwardingHeaders/ in its INTERFACE_INCLUDE_DIRECTORIES.
Attachments
Patch (2.34 KB, patch)
2020-02-27 11:49 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.31 KB, text/plain)
2020-02-27 14:36 PST, Per Arne Vollan 		no flags
Details
Patch (1.98 KB, patch)
2020-02-27 14:41 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2020-02-27 14:45 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-27 11:07:56 PST
<rdar://problem/59853955>
Per Arne Vollan
Comment 2 2020-02-27 11:49:26 PST
Created attachment 391893 [details] Patch
Don Olmstead
Comment 3 2020-02-27 11:55:58 PST
Comment on attachment 391893 [details] Patch This is wrong. You should be setting this to where the headers actually are. I'm guessing you should move the setting of these values into the target files. So like set(WTF_FRAMEWORK_HEADERS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF") Also https://bugs.webkit.org/show_bug.cgi?id=205085 still needs to land
Per Arne Vollan
Comment 4 2020-02-27 13:18:45 PST
(In reply to Don Olmstead from comment #3) > Comment on attachment 391893 [details] > Patch > > This is wrong. You should be setting this to where the headers actually are. > > I'm guessing you should move the setting of these values into the target > files. So like > > set(WTF_FRAMEWORK_HEADERS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF") > It doesn't seem like we used to set this for AppleWin, if I am not mistaken. Is it still needed? Thanks for reviewing!
Per Arne Vollan
Comment 5 2020-02-27 14:36:52 PST
Created attachment 391919 [details] Patch
Per Arne Vollan
Comment 6 2020-02-27 14:41:11 PST
Created attachment 391920 [details] Patch
Per Arne Vollan
Comment 7 2020-02-27 14:45:57 PST
Created attachment 391921 [details] Patch
WebKit Commit Bot
Comment 8 2020-02-27 15:45:21 PST
Comment on attachment 391921 [details] Patch Clearing flags on attachment: 391921 Committed r257595: <https://trac.webkit.org/changeset/257595>
WebKit Commit Bot
Comment 9 2020-02-27 15:45:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.