Summary: | [GTK] media/muted-video-is-playing-audio.html is timing out | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||
Component: | Media | Assignee: | Enrique Ocaña <eocanha> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, crzwdjk, eocanha, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Diego Pino
2020-02-27 08:54:37 PST
The test has been consistently timing out for the last 4000 revisions: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r278650%20%282224%29/media/muted-video-is-playing-audio-diff.txt --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/muted-video-is-playing-audio-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/muted-video-is-playing-audio-actual.txt @@ -1,15 +1,2 @@ -Testing that muting a video element should result in page's audio playing state to become false +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS window.internals.pageMediaState().includes('IsPlayingAudio') became true -PASS window.internals.pageMediaState().includes('IsPlayingAudio') became false -PASS window.internals.pageMediaState().includes('IsPlayingAudio') became true -PASS successfullyParsed is true - -TEST COMPLETE - -RUN(video.muted = true) -RUN(video.muted = false) - Gardened in r278654. Created attachment 432039 [details]
Patch
Created attachment 432046 [details]
Patch
Comment on attachment 432046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432046&action=review LGTM but let's wait until tomorrow to land this and let's ensure the Apple ports do not regress anything. > Source/WebCore/testing/Internals.cpp:4821 > +void Internals::setMediaVolume(float volume) setPageMediaVolume or setPageVolume Created attachment 432054 [details]
Patch
Committed r279217 (239103@main): <https://commits.webkit.org/239103@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432054 [details]. |