Bug 208301
| Summary: | [GTK] Several editing/pasteboard tests are flaky after r244494 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego Pino
The following tests became flaky after r244494 (Defer EditorState updates until the next layer tree flush in a few additional circumstances):
* editing/pasteboard/4922709.html [ Failure Pass ]
* editing/pasteboard/5028447.html [ Failure Pass ]
* editing/pasteboard/paste-before-tab-span.html [ Failure Pass ]
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
Some more other editing/pasteboard tests that sporadically return a flaky failure:
editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html
editing/pasteboard/paste-line-endings-003.html
editing/pasteboard/paste-line-endings-007.html
editing/pasteboard/paste-text-005.html
Diff:
--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/editing/pasteboard/paste-line-endings-007-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/editing/pasteboard/paste-line-endings-007-actual.txt
@@ -13,7 +13,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 9 of #text > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > DIV > BODY > HTML > #document givenAction:WebViewI
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of DIV > DIV > BODY > HTML > #document to 8 of #text > DIV > DIV > DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > DIV > DIV > DIV >
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 9 of #text > DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > DIV > DIV > BODY > H
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -47,8 +47,7 @@
RenderBlock (anonymous) at (2,2) size 780x27
RenderText {#text} at (0,0) size 78x26
text run at (0,0) width 78: "line one"
- RenderBR {BR} at (77,21) size 1x0
RenderBlock {DIV} at (2,29) size 780x27
- RenderText {#text} at (0,0) size 79x26
- text run at (0,0) width 79: "line two"
-caret: position 1 of child 0 {#text} of child 2 {DIV} of child 1 {DIV} of child 3 {DIV} of body
+ RenderText {#text} at (0,0) size 72x26
+ text run at (0,0) width 72: "ine two"
+caret: position 0 of child 0 {#text} of child 1 {DIV} of child 1 {DIV} of child 3 {DIV} of body
--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/editing/pasteboard/paste-text-005-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/editing/pasteboard/paste-text-005-actual.txt
@@ -42,10 +42,12 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV >
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 46 of #text > DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > DIV > BODY > HTML > #docume
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
+EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 33 of #text > DIV > BODY > HTML > #document to 33 of #text > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
@@ -83,10 +85,10 @@
| <div>
| class="editing"
| id="test"
-| "There is a tide in the affairs of men,"
+| "There "
| <div>
| class="editing"
-| "<#selection-caret>Which taken at the flood leads on to fortune."
+| "l<#selection-caret>Which taken at the flood leads on to fortune."
| "
"
| <div>
@@ -108,11 +110,10 @@
| <div>
| class="editing"
| id="test"
-| "There is a tide in the affairs of men,"
+| "There "
| <div>
| class="editing"
-| id="test"
-| "is a tide in the affairs of men,"
+| "lis a tide in the affairs of men,"
| <div>
| class="editing"
| "<#selection-caret>Which taken at the flood leads on to fortune."
Diego Pino
More flaky failures in editing/pasteboard:
editing/pasteboard/copy-null-characters.html
editing/pasteboard/copy-text-with-backgroundcolor.html
editing/pasteboard/copy-text-with-wrapped-tag.html
editing/pasteboard/page-zoom.html
editing/pasteboard/paste-blockquote-and-paragraph-break.html
editing/pasteboard/preserve-line-break-at-end-of-pasted-content.html
editing/pasteboard/testcase-9507.html
editing/pasteboard/copy-null-characters.html (See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r259574%20(13225)/editing/pasteboard/copy-null-characters-diff.txt)
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/copy-null-characters-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/copy-null-characters-actual.txt
@@ -20,16 +20,7 @@
| <div>
| contenteditable="true"
| id="destination-rich-text"
-| <p>
-| <b>
-| "bold"
-| <div>
-| id="source"
-| "Copy paste me"
-| <span>
-| style="color: green;"
-| "green"
-| "Copy paste me"
+| "Copy paste meCopy paste me"
| "
"
| <#selection-caret>
editing/pasteboard/copy-text-with-backgroundcolor.html (See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r259935%20(13299)/editing/pasteboard/copy-text-with-backgroundcolor-diff.txt)
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/copy-text-with-backgroundcolor-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/copy-text-with-backgroundcolor-actual.txt
@@ -21,7 +21,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 22 of #text > SPAN > DIV > DIV > BODY > HTML > #document to 22 of #text > SPAN > DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 22 of #text > SPAN > DIV > DIV > BODY > HTML > #document to 22 of #text > SPAN > DIV > DIV > BODY > HTML > #document toDOMRange:range from 22 of #text > DIV > DIV > BODY > HTML > #document to 22 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 22 of #text > SPAN > DIV > DIV > BODY > HTML > #document to 22 of #text > SPAN > DIV > DIV > BODY > HTML > #document toDOMRange:range from 16 of #text > SPAN > DIV > DIV > BODY > HTML > #document to 16 of #text > SPAN > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
@@ -73,6 +73,8 @@
| <span>
| style="background-color: rgb(255, 0, 0, 0);"
| "Transparent background"
-| "Transparent background<#selection-caret>"
+| <span>
+| style="background-color: rgb(0, 128, 0);"
+| "Green background<#selection-caret>"
| "
"
editing/pasteboard/copy-text-with-wrapped-tag.html (See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r259221%20(13151)/editing/pasteboard/copy-text-with-wrapped-tag-diff.txt)
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/copy-text-with-wrapped-tag-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/copy-text-with-wrapped-tag-actual.txt
@@ -13,7 +13,7 @@
| "AVeryLongWordThatWillWrap<#selection-caret>"
Pasted2:
-| "Copy multiple spaces "
+| "Copy this text "
| <a>
| href="http://www.google.com"
| "AVeryLongWordThatWillWrap<#selection-caret>"
editing/pasteboard/page-zoom.html (See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r259634%20(13237)/editing/pasteboard/page-zoom-diff.txt)
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/page-zoom-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/page-zoom-actual.txt
@@ -1,12 +1,13 @@
+CONSOLE MESSAGE: line 44: relative font size not preserved
Copy this 16px text.
PasteCopy this 16px text it here.
The pasted text should have a font size of 16px.
Copy this x-small text.
-PasteCopy this x-small it here.
+PasteCopy this 16px text it here.
The pasted text should have a font size of x-small.
-PASS
+FAIL (this test requires DRT)
editing/pasteboard/paste-blockquote-and-paragraph-break.html (See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r259634%20(13237)/editing/pasteboard/paste-blockquote-and-paragraph-break-diff.txt)
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/paste-blockquote-and-paragraph-break-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/paste-blockquote-and-paragraph-break-actual.txt
@@ -14,14 +14,8 @@
| <br>
After paste:
-| <blockquote>
-| id="blockquote"
-| type="cite"
-| "hello"
-| <br>
-| <div>
-| <#selection-caret>
-| <br>
+| "hello<#selection-caret>"
+| <br>
| <blockquote>
| id="blockquote"
| type="cite"
@@ -30,14 +24,8 @@
| <br>
After inserting "world":
-| <blockquote>
-| id="blockquote"
-| type="cite"
-| "hello"
-| <br>
-| <div>
-| "world<#selection-caret>"
-| <br>
+| "helloworld<#selection-caret>"
+| <br>
| <blockquote>
| id="blockquote"
| type="cite"
editing/pasteboard/preserve-line-break-at-end-of-pasted-content.html (See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r259592%20(13227)/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-diff.txt)
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-actual.txt
@@ -11,8 +11,10 @@
| "Hello World!"
| <div>
| id="div"
-| "Hello World!"
+| <span>
+| style="caret-color: rgb(0, 0, 255);"
+| "caret-color: blue, "
+| <span>
+| style="caret-color: magenta;"
+| "caret-color: magenta<#selection-caret>"
| <br>
-| <div>
-| <#selection-caret>
-| <br>
editing/pasteboard/testcase-9507.html (See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r259879%20(13281)/editing/pasteboard/testcase-9507-diff.txt)
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/testcase-9507-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/testcase-9507-actual.txt
@@ -28,10 +28,10 @@
| <div>
| class="editing"
| id="test"
-| "foo"
-| <div>
-| style="color: rgb(255, 0, 0);"
-| "bar<#selection-caret>"
+| <img>
+| src="../resources/abe.png"
+| style="text-align: -webkit-center;"
+| <#selection-caret>
| <div>
| style="color: rgb(255, 0, 0);"
| "
Diego Pino
This test(s) has been consistenly passing in the last 4000 revisions. Closing bug.