Bug 208285

Summary:

Remove initial layout throttle

Product:

WebKit

Reporter:

Ben Nham <nham>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, jacob_uphoff, kangil.han, koivisto, nham, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

208536

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Ben Nham

Reported 2020-02-26 21:27:14 PST

Remove initial layout throttler

Attachments
Patch (17.80 KB, patch) 2020-02-26 21:35 PST, Ben Nham	no flags	Details Formatted Diff Diff
Patch (19.30 KB, patch) 2020-02-27 23:48 PST, Ben Nham	no flags	Details Formatted Diff Diff
Patch (27.17 KB, patch) 2020-03-03 10:18 PST, alan	no flags	Details Formatted Diff Diff
Patch (19.26 KB, patch) 2020-03-04 08:55 PST, alan	no flags	Details Formatted Diff Diff
Patch (19.75 KB, patch) 2020-03-04 09:02 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-02-26 21:34:44 PST

<rdar://problem/59835321>

Ben Nham

Comment 2 2020-02-26 21:35:17 PST

Created attachment 391837 [details] Patch

Antti Koivisto

Comment 3 2020-02-26 22:41:07 PST

Comment on attachment 391837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391837&action=review > Source/WebCore/page/SettingsBase.cpp:-67 > -// This amount of time must have elapsed before we will even consider scheduling a layout without a delay. > -// FIXME: For faster machines this value can really be lowered to 200. 250 is adequate, but a little high > -// for dual G5s. :) > -static const Seconds layoutScheduleThreshold = 250_ms; My dual G5s are going to fly!

Ben Nham

Comment 4 2020-02-27 09:51:29 PST

*** Bug 204031 has been marked as a duplicate of this bug. ***

Ben Nham

Comment 5 2020-02-27 23:48:34 PST

Created attachment 391966 [details] Patch

Ben Nham

Comment 6 2020-02-28 09:40:51 PST

Alan said he could take a look at the layout test issues here, so assigning to him. I already put in a couple workarounds for LayoutTests in the latest patch for ios-wk2: - tiled-drawing-async-frame-scrolling.html: the third iframe wasn't in the render tree, which was causing this to fail; worked around this by waiting for the entire window and all iframes to load before starting the test - autoscroll-in-iframe-body.html: I think this was issuing a click event in an iframe before the iframe had rendered There are also a couple of mac-wk2 layout tests that are failing now that are somewhat similar (they attempt to move/click the mouse after an onload event). As Alan said, we should probably remove the workarounds and make sure we fully understand the implications of removing the layout timer.

alan

Comment 7 2020-03-02 21:28:18 PST

LayoutTests/compositing/tiling/tiled-drawing-async-frame-scrolling.html is fixed at r257752

alan

Comment 8 2020-03-03 10:18:07 PST

animations/cross-fade-list-style-image.html is fixed at r257764

alan

Comment 9 2020-03-03 10:18:40 PST

Created attachment 392291 [details] Patch

alan

Comment 10 2020-03-03 19:41:49 PST

fast/images/animated-gif-no-layout.html is fixed at r257811