Summary: | Optimize Path::encode on platforms that support CGPathGetNumberOfElements | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, darin, jonlee, sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Wenson Hsieh
2020-02-26 14:40:07 PST
Created attachment 392072 [details]
Patch
Comment on attachment 392072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392072&action=review Do you know the reason for the mysterious Windows failure? It does seem to be new to the patch. > Source/WebCore/platform/graphics/Path.h:136 > + WEBCORE_EXPORT unsigned elementCount() const; 32-bit here > Source/WebCore/platform/graphics/Path.h:234 > + encoder << static_cast<uint64_t>(elementCount()); 64-bit here Why? Comment on attachment 392072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392072&action=review >> Source/WebCore/platform/graphics/Path.h:234 >> + encoder << static_cast<uint64_t>(elementCount()); > > 64-bit here > > Why? Good catch! No compelling reason for this difference. elementCount() should return a uint64_t, and then we could just remove the static_cast here. > Do you know the reason for the mysterious Windows failure? It does seem to
> be new to the patch.
After using the new Retry button, it looks like this was just an unrelated flaky failure (the Win bot is green). The patch should not have changed any behavior on non-Cocoa ports.
Created attachment 392116 [details]
Address comments
Comment on attachment 392116 [details] Address comments View in context: https://bugs.webkit.org/attachment.cgi?id=392116&action=review > Source/WebCore/platform/graphics/Path.h:136 > + WEBCORE_EXPORT uint64_t elementCount() const; Why not size_t Comment on attachment 392116 [details] Address comments View in context: https://bugs.webkit.org/attachment.cgi?id=392116&action=review >> Source/WebCore/platform/graphics/Path.h:136 >> + WEBCORE_EXPORT uint64_t elementCount() const; > > Why not size_t Sure, I suppose that would be clearer. Created attachment 392183 [details]
Address smfr's comment
The commit-queue encountered the following flaky tests while processing attachment 392183 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 392183 [details] Address smfr's comment Clearing flags on attachment: 392183 Committed r257918: <https://trac.webkit.org/changeset/257918> All reviewed patches have been landed. Closing bug. |