Bug 208240

Summary: Conversion between MediaSample and RemoteVideoSample should preserve the rotation information
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, jacob_uphoff, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2020-02-26 05:41:13 PST
Conversion between MediaSample and RemoteVideoSample should preserve the rotation information
Attachments
Patch (8.74 KB, patch)
2020-02-26 05:47 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.76 KB, patch)
2020-02-27 18:59 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.75 KB, patch)
2020-02-28 00:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-26 05:47:02 PST
Created attachment 391743 [details] Patch
WebKit Commit Bot
Comment 2 2020-02-26 07:29:41 PST
Comment on attachment 391743 [details] Patch Clearing flags on attachment: 391743 Committed r257470: <https://trac.webkit.org/changeset/257470>
WebKit Commit Bot
Comment 3 2020-02-26 07:29:43 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-02-26 07:30:19 PST
<rdar://problem/59805022>
Jacob Uphoff
Comment 5 2020-02-26 09:53:10 PST
Reverted r257470 for reason: This broke the build for tvOS and watchOS Committed r257479: <https://trac.webkit.org/changeset/257479>
youenn fablet
Comment 6 2020-02-27 18:59:53 PST
Created attachment 391955 [details] Patch for landing
WebKit Commit Bot
Comment 7 2020-02-27 19:08:41 PST
Comment on attachment 391955 [details] Patch for landing Rejecting attachment 391955 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 391955, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13330263
youenn fablet
Comment 8 2020-02-28 00:57:29 PST
Created attachment 391969 [details] Patch for landing
WebKit Commit Bot
Comment 9 2020-02-28 03:28:41 PST
Comment on attachment 391969 [details] Patch for landing Clearing flags on attachment: 391969 Committed r257633: <https://trac.webkit.org/changeset/257633>
WebKit Commit Bot
Comment 10 2020-02-28 03:28:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.