Bug 208234

Summary: [GStreamer] Correctly remove webvttenc on WebKitTextCombiner pad release
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, commit-queue, ews-watchlist, gustavo, menard, pnormand, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2020-02-26 04:29:50 PST
The implementation of webkitTextCombinerReleasePad() was wrong in that it was checking the peer pad of webkittextcombinerpad to check if it belonged a webvttenc element and remove it... But since this is a ghostpad, the peer is upstream, not downstream. When the release pad function is called, upstream is already disconnected, so the branch was never hit. To actually remove the webvttenc element we must check the target pad instead of the peer pad, which corresponds to the element downstream. Also, we need to set the element state to NULL before removing it, which the previous code didn't.
Attachments
Patch (2.73 KB, patch)
2020-02-26 04:32 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2020-02-26 04:32:32 PST
Created attachment 391735 [details] Patch
WebKit Commit Bot
Comment 2 2020-02-26 06:45:34 PST
Comment on attachment 391735 [details] Patch Clearing flags on attachment: 391735 Committed r257468: <https://trac.webkit.org/changeset/257468>
WebKit Commit Bot
Comment 3 2020-02-26 06:45:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.