Bug 208127

Summary: Protect from null session in NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2020-02-24 02:21:30 PST
Protect from null session in NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded
Comment 1 youenn fablet 2020-02-24 02:30:29 PST
<rdar://problem/57937917>
Comment 2 youenn fablet 2020-02-24 02:31:27 PST
Created attachment 391520 [details]
Patch
Comment 3 youenn fablet 2020-02-24 02:44:22 PST
It seems that we should fail all NetworkResourceLoader when the corresponding session goes away. For now, protecting NetworkDataTask seems fine.
Comment 4 WebKit Commit Bot 2020-02-24 08:41:48 PST
The commit-queue encountered the following flaky tests while processing attachment 391520 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-02-24 08:42:23 PST
Comment on attachment 391520 [details]
Patch

Clearing flags on attachment: 391520

Committed r257209: <https://trac.webkit.org/changeset/257209>
Comment 6 WebKit Commit Bot 2020-02-24 08:42:24 PST
All reviewed patches have been landed.  Closing bug.