Bug 208120

Summary: [GTK] fast/mediastream/media-element-current-time.html is failing since added in r256346
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Philippe Normand <philn>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, philn, pnormand, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Diego Pino
Reported 2020-02-24 00:01:09 PST
* fast/mediastream/media-element-current-time.html [ Failure ] --- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/fast/mediastream/media-element-current-time-expected.txt +++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/fast/mediastream/media-element-current-time-actual.txt @@ -1,4 +1,4 @@ -PASS Check video.currentTime behavior +FAIL Check video.currentTime behavior assert_not_equals: Playback has started, currentTime must not be zero got disallowed value 0
Attachments
Patch (2.65 KB, patch)
2021-12-27 20:27 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-06-17 09:15:28 PDT
I think the way this test was written kind of makes it prone to flakiness. Changing the playback state and waiting 10ms until performing a test is not great for the gst engine. It would be better to rely on events.
Philippe Normand
Comment 2 2021-12-22 06:50:18 PST
Current failure is: -PASS Check video.currentTime behavior +FAIL Check video.currentTime behavior assert_greater_than: video is playing, time should advance expected a number greater than 0.284381 but got 0.284381 Which happens because the position is queried immediately after the play() call. Waiting 10ms gives time to the engine to have the pipeline position going forward.
Diego Pino
Comment 3 2021-12-27 20:27:08 PST
Created attachment 448027 [details] Patch
EWS
Comment 4 2021-12-28 17:17:14 PST
Committed r287477 (245612@main): <https://commits.webkit.org/245612@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448027 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-28 17:18:20 PST
<rdar://problem/86967699>
Philippe Normand
Comment 6 2022-08-07 01:57:22 PDT
This is still very flaky. (In reply to Philippe Normand from comment #1) > I think the way this test was written kind of makes it prone to flakiness. > Changing the playback state and waiting 10ms until performing a test is not > great for the gst engine. > > It would be better to rely on events. Patch incoming...
Philippe Normand
Comment 7 2022-08-07 01:59:53 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3085
EWS
Comment 8 2022-08-08 10:48:22 PDT
Committed 253220@main (3e994a2e3142): <https://commits.webkit.org/253220@main> Reviewed commits have been landed. Closing PR #3085 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.