Bug 208055

Summary: REGRESSION (r257126): fast/frames/flattening/iframe-tiny.html is flaky failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: FramesAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jacob Uphoff
Reported 2020-02-21 07:49:37 PST
fast/frames/flattening/iframe-tiny.html This test started to flaky fail and was first seen on commit r256129. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fflattening%2Fiframe-tiny.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/frames/flattening/iframe-tiny-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/frames/flattening/iframe-tiny-actual.txt @@ -13,8 +13,8 @@ PASS getComputedStyle(frame, 0).width is '7px' PASS getComputedStyle(frame, 0).height is '7px' testFrame3 -PASS getComputedStyle(frame, 0).width is '400px' -PASS getComputedStyle(frame, 0).height is '400px' +FAIL getComputedStyle(frame, 0).width should be 400px. Was 16px. +FAIL getComputedStyle(frame, 0).height should be 400px. Was 8px. testFrame4 PASS getComputedStyle(frame, 0).width is '0px' PASS getComputedStyle(frame, 0).height is '100px' @@ -34,11 +34,11 @@ PASS getComputedStyle(frame, 0).width is '300px' PASS getComputedStyle(frame, 0).height is '2px' testFrame10 -PASS getComputedStyle(frame, 0).width is '400px' -PASS getComputedStyle(frame, 0).height is '400px' +FAIL getComputedStyle(frame, 0).width should be 400px. Was 16px. +FAIL getComputedStyle(frame, 0).height should be 400px. Was 150px. testFrame11 -PASS getComputedStyle(frame, 0).width is '400px' -PASS getComputedStyle(frame, 0).height is '400px' +FAIL getComputedStyle(frame, 0).width should be 400px. Was 300px. +FAIL getComputedStyle(frame, 0).height should be 400px. Was 8px. PASS successfullyParsed is true TEST COMPLETE
Attachments
Patch (1.38 KB, patch)
2020-02-24 12:53 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.10 KB, patch)
2020-02-24 15:49 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-21 07:51:40 PST
<rdar://problem/59668089>
Alexey Proskuryakov
Comment 2 2020-02-22 16:50:38 PST
Jacob's revision has a typo. The first time this happened was r257127, so this is almost certainly http://trac.webkit.org/r257126. Also, this is happening 100% on the GuardMalloc bot.
zalan
Comment 3 2020-02-22 16:54:22 PST
Ok. It looks like some timing issue. Most likely it's missing some forced layout (since the test seemed to rely on an optional layout).
zalan
Comment 4 2020-02-24 12:53:36 PST
Created attachment 391569 [details] Patch
zalan
Comment 5 2020-02-24 15:49:38 PST
Created attachment 391589 [details] Patch
WebKit Commit Bot
Comment 6 2020-02-24 16:39:45 PST
The commit-queue encountered the following flaky tests while processing attachment 391589 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-02-24 16:40:19 PST
Comment on attachment 391589 [details] Patch Clearing flags on attachment: 391589 Committed r257280: <https://trac.webkit.org/changeset/257280>
WebKit Commit Bot
Comment 8 2020-02-24 16:40:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.