Bug 208046

Summary: [GStreamer][WPE] Add GstGLMemoryEGL support for the video-plane-display
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch zan: review+

Philippe Normand
Reported 2020-02-21 02:05:55 PST
Also ensure the stride is valid.
Attachments
Patch (4.05 KB, patch)
2020-02-21 02:09 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (4.06 KB, patch)
2020-02-21 03:23 PST, Philippe Normand 		zan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-02-21 02:09:44 PST
Created attachment 391389 [details] Patch
Philippe Normand
Comment 2 2020-02-21 03:23:50 PST
Created attachment 391390 [details] Patch
Zan Dobersek
Comment 3 2020-02-21 03:43:37 PST
Comment on attachment 391390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391390&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:224 > + if (hasDMABuf() && (m_dmabufStride == -1)) { Extra parentheses not necessary, but OK. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:226 > + m_isMapped = gst_video_frame_map(&m_videoFrame, &videoInfo, m_buffer.get(), GST_MAP_READ); > + RELEASE_ASSERT(m_isMapped); Is this really a given? or can it fail in some obscure fashion, now or in the future?
Philippe Normand
Comment 4 2020-02-24 01:10:45 PST
(In reply to Zan Dobersek from comment #3) > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:226 > > + m_isMapped = gst_video_frame_map(&m_videoFrame, &videoInfo, m_buffer.get(), GST_MAP_READ); > > + RELEASE_ASSERT(m_isMapped); > > Is this really a given? or can it fail in some obscure fashion, now or in > the future? It can fail indeed, especially if no video meta is attached to the buffer. I'll relax this ASSERT.
Philippe Normand
Comment 5 2020-02-24 01:14:08 PST
Committed r257202: <https://trac.webkit.org/changeset/257202>
Radar WebKit Bug Importer
Comment 6 2020-02-24 01:15:16 PST
<rdar://problem/59718023>
Note You need to log in before you can comment on or make changes to this bug.