Bug 207929

Summary:

[iOS] Safari sometimes crashes under ViewGestureController::beginSwipeGesture

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, cdumez, commit-queue, ddkilzer, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
With logging	thorton: review+, commit-queue: commit-queue-

Wenson Hsieh

Reported 2020-02-18 21:43:22 PST

<rdar://problem/59493326>

Attachments
Patch (2.58 KB, patch) 2020-02-18 22:26 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (3.82 KB, patch) 2020-02-19 08:01 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
With logging (3.96 KB, patch) 2020-02-19 08:58 PST, Wenson Hsieh	thorton: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2020-02-18 22:26:46 PST Comment hidden (obsolete)

Created attachment 391144 [details] Patch

Tim Horton

Comment 2 2020-02-18 22:50:03 PST

Please make sure that the SPI notifications are all called (and layer tree unfreeze, etc.)

Wenson Hsieh

Comment 3 2020-02-19 07:49:43 PST

(In reply to Tim Horton from comment #2) > Please make sure that the SPI notifications are all called (and layer tree > unfreeze, etc.) Good point! With my first patch, -_webViewDidBeginNavigationGesture: could get called before bailing from the null check, which would lead to imbalanced SPI delegate calls (to be fair, only in the case where we would otherwise crash the UI process). Another approach I tried initially was to move the null check before the didBegin call, such that the delegate would never need to be notified in the first place. I avoided this out of compat fear (i.e. the case where a client could depend on being able to adjust the back/forward list right before we proceed with the swipe). I think I’ll go for this original approach again, and double check to see if any of our clients actually take advantage of this functionality.

Wenson Hsieh

Comment 4 2020-02-19 08:01:43 PST Comment hidden (obsolete)

Created attachment 391162 [details] Patch

Wenson Hsieh

Comment 5 2020-02-19 08:58:30 PST

Created attachment 391167 [details] With logging

WebKit Commit Bot

Comment 6 2020-02-19 12:02:07 PST Comment hidden (obsolete)

Comment on attachment 391167 [details] With logging Rejecting attachment 391167 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 391167, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=391167&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=207929&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 391167 from bug 207929. Fetching: https://bugs.webkit.org/attachment.cgi?id=391167 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 02872ca4de37ce8abb9f24539e6131a494d99f79 and refs/remotes/origin/master differ, using rebase: :040000 040000 8eda8b0881abd09af3f366367f3e00ea187ff52d 0fef4b909914541ddd6f65f343682f60dc70c834 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 02872ca4de37ce8abb9f24539e6131a494d99f79 and refs/remotes/origin/master differ, using rebase: :040000 040000 8eda8b0881abd09af3f366367f3e00ea187ff52d 0fef4b909914541ddd6f65f343682f60dc70c834 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 232710f76d0..b2520a42dab master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 256930 = 232710f76d02a19aec9a30134beaf5c350399a58 r256931 = b2520a42dab0579f68010daf84fc2cf4b70ad2cc Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13325104

Wenson Hsieh

Comment 7 2020-02-19 12:05:03 PST

Committed r256933: <https://trac.webkit.org/changeset/256933>

Note You need to log in before you can comment on or make changes to this bug.