Bug 207914

Summary: [PlayStation] Get jsc test wrappers using find_package
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ross.kirsling, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2020-02-18 15:07:26 PST
Right now JSC is getting the playstation specific test wrappers for the shell via find_library and some manual setting of wrappers that become --Wl,--wrap= arguments. This has the problem that when adding wrappers that call the real function, the shell fails to build until the cmake is changed. Downstream, we've moved to using find_package and having the library provide the correct arguments and dependencies via a config cmake.
Attachments
Patch (1.80 KB, patch)
2020-02-19 10:59 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2020-02-19 10:59:35 PST
Created attachment 391178 [details] Patch
WebKit Commit Bot
Comment 2 2020-02-19 11:46:19 PST
Comment on attachment 391178 [details] Patch Clearing flags on attachment: 391178 Committed r256930: <https://trac.webkit.org/changeset/256930>
WebKit Commit Bot
Comment 3 2020-02-19 11:46:21 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-02-19 11:47:15 PST
<rdar://problem/59599495>
Note You need to log in before you can comment on or make changes to this bug.