Bug 207850

Summary: Update WebKit Tools to issue mach extensions as needed
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, peng.liu6, pvollan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207743
Attachments:
Description Flags
Patch pvollan: review+

Brent Fulgham
Reported 2020-02-17 12:14:37 PST
Now that we have sandboxed the various tool projects (WebKitTestRunner, TestWebKitAPI, and MiniBrowser), we need to grant them the ability to issue mach extensions to various services needed by the WebContent, Network, and GPU processes. We probably need to get this added to an appropriate system sandbox, but for now we can use a workaround to allow test features to work properly.
Attachments
Patch (6.16 KB, patch)
2020-02-17 12:20 PST, Brent Fulgham 		pvollan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-17 12:17:37 PST
<rdar://problem/59521019>
Brent Fulgham
Comment 2 2020-02-17 12:20:56 PST
Created attachment 390959 [details] Patch
Per Arne Vollan
Comment 3 2020-02-17 14:29:44 PST
Comment on attachment 390959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390959&action=review R=me. > Tools/TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:8 > + <key>keychain-access-groups</key> > + <array> > + <string>com.apple.TestWebKitAPI</string> > + </array> Is this needed?
Brent Fulgham
Comment 4 2020-02-17 14:54:30 PST
Comment on attachment 390959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390959&action=review >> Tools/TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:8 >> + </array> > > Is this needed? Maybe not. We do have that in the WKTR entitlements, but I guess it was never needed previously. I'll take it out.
Brent Fulgham
Comment 5 2020-02-17 14:54:32 PST
Committed r256777: <https://trac.webkit.org/changeset/256777>
Note You need to log in before you can comment on or make changes to this bug.