Bug 207837

Summary: [macOS] Add trace points for layer flush runloop observer
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, nham, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch
sam: review+
patch none

Antti Koivisto
Reported 2020-02-17 05:03:46 PST
Add trace points to see how much layer flushes get delayed.
Attachments
patch (4.56 KB, patch)
2020-02-17 05:19 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (4.57 KB, patch)
2020-02-17 05:25 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (6.40 KB, patch)
2020-02-17 06:51 PST, Antti Koivisto 		sam: review+
DetailsFormatted DiffDiff
patch (6.39 KB, patch)
2020-02-17 08:00 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-02-17 05:19:50 PST
Created attachment 390914 [details] patch
Antti Koivisto
Comment 2 2020-02-17 05:25:59 PST
Created attachment 390915 [details] patch
Antti Koivisto
Comment 3 2020-02-17 06:51:42 PST
Created attachment 390917 [details] patch
Sam Weinig
Comment 4 2020-02-17 07:54:56 PST
Comment on attachment 390917 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=390917&action=review > Source/WTF/ChangeLog:3 > + [MacOS] Add trace points for layer flush runloop observer lowercase m in [macOS]. > Source/WTF/wtf/SystemTracing.h:108 > + LayerTreeFreezeStart, > + LayerTreeFreezeEnd, Should mention these in the change log as well.
Antti Koivisto
Comment 5 2020-02-17 08:00:51 PST
Created attachment 390919 [details] patch
Antti Koivisto
Comment 6 2020-02-17 08:01:32 PST
> Should mention these in the change log as well. It was mentioned in WebKit changelog (where the other comments were).
WebKit Commit Bot
Comment 7 2020-02-17 08:45:33 PST
Comment on attachment 390919 [details] patch Clearing flags on attachment: 390919 Committed r256736: <https://trac.webkit.org/changeset/256736>
WebKit Commit Bot
Comment 8 2020-02-17 08:45:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-02-17 08:46:14 PST
<rdar://problem/59512045>
Note You need to log in before you can comment on or make changes to this bug.