Bug 207759

Summary: When updating a subtree of the IsolatedTree, first remove the entire subtree, not just the subtree root.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2020-02-14 07:03:20 PST
When updating a subtree of the IsolatedTree, first remove the entire subtree, not just the subtree root.
Attachments
Patch (9.08 KB, patch)
2020-02-14 07:28 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (9.34 KB, patch)
2020-02-14 09:23 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-02-14 07:28:19 PST
Created attachment 390764 [details] Patch
chris fleizach
Comment 2 2020-02-14 08:47:47 PST
Comment on attachment 390764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390764&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:215 > + ASSERT(m_readerThreadNodeMap.get(item.m_isolatedObject->objectID())->refCount() == 2); can you add a comment why refCount must be two here
Andres Gonzalez
Comment 3 2020-02-14 09:23:22 PST
Created attachment 390775 [details] Patch
WebKit Commit Bot
Comment 4 2020-02-14 11:22:38 PST
Comment on attachment 390775 [details] Patch Clearing flags on attachment: 390775 Committed r256630: <https://trac.webkit.org/changeset/256630>
WebKit Commit Bot
Comment 5 2020-02-14 11:22:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-02-14 11:23:17 PST
<rdar://problem/59465611>
Note You need to log in before you can comment on or make changes to this bug.