Bug 207748

Summary: Null Ptr Deref @ WebCore::Node::Treescope
Product: WebKit Reporter: Pinki Gyanchandani <pgyanchandani>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ajuma, cdumez, commit-queue, darin, dbates, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, rniwa, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Pinki Gyanchandani
Reported 2020-02-14 00:01:42 PST
Null Ptr Deref @ WebCore::Node::Treescope
Attachments
Patch (4.04 KB, patch)
2020-02-14 00:32 PST, Pinki Gyanchandani 		no flags
DetailsFormatted DiffDiff
Patch (4.41 KB, patch)
2020-02-14 13:52 PST, Pinki Gyanchandani 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2020-02-17 11:40 PST, Pinki Gyanchandani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pinki Gyanchandani
Comment 1 2020-02-14 00:32:06 PST
Created attachment 390735 [details] Patch
Ryosuke Niwa
Comment 2 2020-02-14 00:50:34 PST
Comment on attachment 390735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390735&action=review r- due to the issues listed below. > Source/WebCore/ChangeLog:6 > + Reviewed by Ryosuke Niwa. This is definitely not reviewed by me yet. Please undo this and say NOBODY (OOPS!). > Source/WebCore/html/HTMLTextFormControlElement.cpp:307 > + if (!isTextField()) > + return; Let's check this before getting innerText. It's weird to try to update innerText if it's not a text field > LayoutTests/ChangeLog:6 > + Reviewed by Ryosuke Niwa NOBODY. Ditto. This is definitely not reviewed by me. In fact, since I wrote this case, it's not appropriate for me to review this test. > LayoutTests/ChangeLog:8 > + Added a regression test to verify the fix Missing a period at the end. Also, we need to give the test author (me in this case) a credit in this case. Say something like: "Added a regression test to verify the fix based on a test case written by Ryosuke Niwa". > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:1 > +<html> Missing <!DOCTYPE html>. > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:11 > + const input3 = document.createElement('input'); Please rename this to inputWithAutofocus or something. > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:22 > + Please remove this blank lines. > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:24 > +<p>Testcase passes if there is no crash </p> "Testcase" should be "test case" but I think we should just say "This test". > LayoutTests/editing/selection/ignore-selection-range-on-input-style-change.html:25 > + Ditto.
Pinki Gyanchandani
Comment 3 2020-02-14 13:52:14 PST
Created attachment 390810 [details] Patch
Darin Adler
Comment 4 2020-02-16 16:17:39 PST
Comment on attachment 390810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390810&action=review > Source/WebCore/html/HTMLTextFormControlElement.cpp:308 > + Should not make this white space change.
Pinki Gyanchandani
Comment 5 2020-02-17 11:40:49 PST
Created attachment 390950 [details] Patch
WebKit Commit Bot
Comment 6 2020-02-17 13:13:08 PST
Comment on attachment 390950 [details] Patch Clearing flags on attachment: 390950 Committed r256764: <https://trac.webkit.org/changeset/256764>
WebKit Commit Bot
Comment 7 2020-02-17 13:13:10 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 8 2020-02-17 13:36:30 PST
<rdar://problem/58923336>
Ryosuke Niwa
Comment 9 2020-02-27 17:29:19 PST
*** Bug 208306 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.