Summary: | Dynamically generate media-related mach connections when not using the GPU Process | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||||
Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, cdumez, commit-queue, pvollan, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=207850 | ||||||||||||
Attachments: |
|
Description
Brent Fulgham
2020-02-13 21:25:43 PST
Created attachment 390728 [details]
Patch
Comment on attachment 390728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390728&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:377 > + SandboxExtension::createHandleForMachLookup("com.apple.nesessionmanager", WTF::nullopt, managerHandle); I think the multiple WTFMove(handle) calls might do something wrong. @Chris: Does the right thing happen if we pass a moved object to a method taking a reference to be assigned to? Comment on attachment 390728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390728&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-126 > - (xpc-service-name "com.apple.audio.toolbox.reporting.service"))) This service does not seem to appear elsewhere in the patch, or am I mistaken? > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-212 > - (xpc-service-name "com.apple.MediaPlayer.RemotePlayerService")) Ditto. Comment on attachment 390728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390728&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:226 > + "com.apple.coremedia.volumecontroller.xpc", "com.apple.accessibility.mediaaccessibilityd", The service "com.apple.accessibility.mediaaccessibilityd" does not seem to have been removed from the macOS sandbox. (In reply to Per Arne Vollan from comment #5) > Comment on attachment 390728 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390728&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:226 > > + "com.apple.coremedia.volumecontroller.xpc", "com.apple.accessibility.mediaaccessibilityd", > > The service "com.apple.accessibility.mediaaccessibilityd" does not seem to > have been removed from the macOS sandbox. Whoops! I'll definitely fix that. Created attachment 390795 [details]
Patch
Created attachment 390797 [details]
Patch
Comment on attachment 390797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390797&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:855 > + "com.apple.audio.AudioComponentRegistrar" "com.apple.audio.AudioSession" "com.apple.MediaPlayer.RemotePlayerService" > + "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.admin" "com.apple.coremedia.asset.xpc" I think "com.apple.audio.toolbox.reporting.service" and "com.apple.MediaPlayer.RemotePlayerService" needs to be in a separate extension rule covering xpc-service-name. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:852 > + "com.apple.accessibility.mediaaccessibilityd" I think this service should be in a separate extension rule covering xpc-service-name. Created attachment 390819 [details]
Patch
Comment on attachment 390797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390797&action=review >> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:855 >> + "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.admin" "com.apple.coremedia.asset.xpc" > > I think "com.apple.audio.toolbox.reporting.service" and "com.apple.MediaPlayer.RemotePlayerService" needs to be in a separate extension rule covering xpc-service-name. Done. >> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:852 >> + "com.apple.accessibility.mediaaccessibilityd" > > I think this service should be in a separate extension rule covering xpc-service-name. Done. Comment on attachment 390819 [details]
Patch
Looks good! R=me.
Comment on attachment 390819 [details] Patch Clearing flags on attachment: 390819 Committed r256660: <https://trac.webkit.org/changeset/256660> All reviewed patches have been landed. Closing bug. |