Bug 207717

Summary: iOS: Autoscrolling is too fast and way too aggressive
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, megan_gardner, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2020-02-13 13:00:21 PST
iOS: Autoscrolling is too fast and way too aggressive
Attachments
Patch (11.97 KB, patch)
2020-02-13 13:00 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (12.00 KB, patch)
2020-02-13 15:21 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-02-13 13:00:49 PST
Created attachment 390682 [details] Patch
Tim Horton
Comment 2 2020-02-13 13:00:51 PST
<rdar://problem/59208122>
Simon Fraser (smfr)
Comment 3 2020-02-13 13:38:19 PST
Comment on attachment 390682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390682&action=review I am saddened by the lack of tests. > Source/WebCore/page/EventHandler.h:631 > bool m_isAutoscrolling { false }; Please move this bool up. > Source/WebCore/page/ios/EventHandlerIOS.mm:627 > + if (autoscrollDelta.height() < insetDistanceThreshold) Blank line above please. > Source/WebCore/page/ios/EventHandlerIOS.mm:637 > + float distanceFromEdge = autoscrollPoint.x() - insetUnobscuredRootViewRect.x(); Do you want negative distanceFromEdge here? > Source/WebCore/page/ios/EventHandlerIOS.mm:646 > + float distanceFromEdge = autoscrollPoint.y() - insetUnobscuredRootViewRect.y(); Ditto.
Tim Horton
Comment 4 2020-02-13 15:21:58 PST
Created attachment 390694 [details] Patch
Tim Horton
Comment 5 2020-02-13 15:24:34 PST
https://trac.webkit.org/changeset/256564/webkit
Note You need to log in before you can comment on or make changes to this bug.