Summary: | iOS: Autoscrolling is too fast and way too aggressive | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, megan_gardner, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2020-02-13 13:00:21 PST
Created attachment 390682 [details]
Patch
Comment on attachment 390682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390682&action=review I am saddened by the lack of tests. > Source/WebCore/page/EventHandler.h:631 > bool m_isAutoscrolling { false }; Please move this bool up. > Source/WebCore/page/ios/EventHandlerIOS.mm:627 > + if (autoscrollDelta.height() < insetDistanceThreshold) Blank line above please. > Source/WebCore/page/ios/EventHandlerIOS.mm:637 > + float distanceFromEdge = autoscrollPoint.x() - insetUnobscuredRootViewRect.x(); Do you want negative distanceFromEdge here? > Source/WebCore/page/ios/EventHandlerIOS.mm:646 > + float distanceFromEdge = autoscrollPoint.y() - insetUnobscuredRootViewRect.y(); Ditto. Created attachment 390694 [details]
Patch
|