Bug 20770

Summary:

Make transform animation behavior match spec

Product:

WebKit

Reporter:

Chris Marrin <cmarrin>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

20758

Attachments:

Description	Flags
Patch, including LayoutTest files	hyatt: review+
Replacement patch - now against changelist 36358	none

Description Chris Marrin 2008-09-10 13:20:57 PDT

The latest version of the CSS Animation and CSS Transition specs give rules for how to handle animation between transform lists. Basically, if the lists match in size and the corresponding operators in the list match, animation is done on an operation-by-operation basis. Otherwise, the lists are reduced to and AffineTransform and those are animated as described in https://bugs.webkit.org/show_bug.cgi?id=20667.

Comment 1 Chris Marrin 2008-09-10 13:29:46 PDT

Created attachment 23327 [details]
Patch, including LayoutTest files

Comment 2 Dave Hyatt 2008-09-11 15:15:35 PDT

Comment on attachment 23327 [details]
Patch, including LayoutTest files

r=me

Comment 3 Chris Marrin 2008-09-12 17:09:49 PDT

Created attachment 23382 [details]
Replacement patch - now against changelist 36358

Comment 4 Dean Jackson 2008-09-12 17:34:30 PDT

Committed r36362
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/style/RenderStyle.cpp
	M	WebCore/rendering/style/RenderStyle.h
	M	WebCore/ChangeLog
	M	WebCore/css/CSSStyleSelector.cpp
	M	WebCore/css/CSSStyleSelector.h
	M	WebCore/page/animation/AnimationBase.h
	M	WebCore/page/animation/ImplicitAnimation.h
	M	WebCore/page/animation/KeyframeAnimation.cpp
	M	WebCore/page/animation/KeyframeAnimation.h
	M	WebCore/page/animation/AnimationBase.cpp
	M	WebCore/page/animation/ImplicitAnimation.cpp
	M	LayoutTests/ChangeLog

Comment 5 Dean Jackson 2008-09-15 17:46:30 PDT

Committed r36468
	M	LayoutTests/ChangeLog
	A	LayoutTests/transitions/transform-op-list-match.html
	A	LayoutTests/transitions/transform-op-list-no-match-expected.txt
	A	LayoutTests/transitions/transform-op-list-match-expected.txt
	A	LayoutTests/transitions/transform-op-list-no-match.html