Bug 20770

Summary: Make transform animation behavior match spec
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20758    
Attachments:
Description Flags
Patch, including LayoutTest files
hyatt: review+
Replacement patch - now against changelist 36358 none

Chris Marrin
Reported 2008-09-10 13:20:57 PDT
The latest version of the CSS Animation and CSS Transition specs give rules for how to handle animation between transform lists. Basically, if the lists match in size and the corresponding operators in the list match, animation is done on an operation-by-operation basis. Otherwise, the lists are reduced to and AffineTransform and those are animated as described in https://bugs.webkit.org/show_bug.cgi?id=20667.
Attachments
Patch, including LayoutTest files (69.26 KB, patch)
2008-09-10 13:29 PDT, Chris Marrin 		hyatt: review+
DetailsFormatted DiffDiff
Replacement patch - now against changelist 36358 (61.35 KB, patch)
2008-09-12 17:09 PDT, Chris Marrin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2008-09-10 13:29:46 PDT
Created attachment 23327 [details] Patch, including LayoutTest files
Dave Hyatt
Comment 2 2008-09-11 15:15:35 PDT
Comment on attachment 23327 [details] Patch, including LayoutTest files r=me
Chris Marrin
Comment 3 2008-09-12 17:09:49 PDT
Created attachment 23382 [details] Replacement patch - now against changelist 36358
Dean Jackson
Comment 4 2008-09-12 17:34:30 PDT
Committed r36362 M WebCore/rendering/RenderLayer.cpp M WebCore/rendering/style/RenderStyle.cpp M WebCore/rendering/style/RenderStyle.h M WebCore/ChangeLog M WebCore/css/CSSStyleSelector.cpp M WebCore/css/CSSStyleSelector.h M WebCore/page/animation/AnimationBase.h M WebCore/page/animation/ImplicitAnimation.h M WebCore/page/animation/KeyframeAnimation.cpp M WebCore/page/animation/KeyframeAnimation.h M WebCore/page/animation/AnimationBase.cpp M WebCore/page/animation/ImplicitAnimation.cpp M LayoutTests/ChangeLog
Dean Jackson
Comment 5 2008-09-15 17:46:30 PDT
Committed r36468 M LayoutTests/ChangeLog A LayoutTests/transitions/transform-op-list-match.html A LayoutTests/transitions/transform-op-list-no-match-expected.txt A LayoutTests/transitions/transform-op-list-match-expected.txt A LayoutTests/transitions/transform-op-list-no-match.html
Note You need to log in before you can comment on or make changes to this bug.