Summary: | Rename SerializedPlatformRepresentation to SerializedPlatformDataCue | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | annulen, calvaris, cdumez, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Eric Carlson
2020-02-13 07:24:53 PST
Created attachment 390641 [details]
Patch
Created attachment 390647 [details]
Patch
Comment on attachment 390647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390647&action=review > Source/WebCore/html/track/DataCue.cpp:119 > + const SerializedPlatformDataCue* otherPlatformValue = dataCue->platformValue(); s/SerializedPlatformDataCue/auto/ > Source/WebCore/platform/SerializedPlatformDataCue.h:2 > + * Copyright (C) 2014 Apple Inc. All rights reserved. 2020? > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:38 > +class SerializedPlatformDataCueMac : public SerializedPlatformDataCue { final? > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:46 > + bool isEqual(const SerializedPlatformDataCue&) const override; final here and above? > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:53 > + SerializedPlatformDataCueMac(id nativeValue); explicit. Need to update cmake build probably Source/WebCore/Headers.cmake Created attachment 390650 [details]
Patch for landing
Created attachment 390652 [details]
Patch for landing
Comment on attachment 390652 [details] Patch for landing Clearing flags on attachment: 390652 Committed r256536: <https://trac.webkit.org/changeset/256536> All reviewed patches have been landed. Closing bug. |