Bug 207695

Summary: Rename SerializedPlatformRepresentation to SerializedPlatformDataCue
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, calvaris, cdumez, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Eric Carlson
Reported 2020-02-13 07:24:53 PST
Rename SerializedPlatformRepresentation to SerializedPlatformDataCue
Attachments
Patch (52.50 KB, patch)
2020-02-13 07:35 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (58.87 KB, patch)
2020-02-13 08:25 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (60.06 KB, patch)
2020-02-13 08:41 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (60.04 KB, patch)
2020-02-13 08:46 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-13 07:25:07 PST
<rdar://problem/59422673>
Eric Carlson
Comment 2 2020-02-13 07:35:00 PST
Created attachment 390641 [details] Patch
Eric Carlson
Comment 3 2020-02-13 08:25:34 PST
Created attachment 390647 [details] Patch
youenn fablet
Comment 4 2020-02-13 08:29:17 PST
Comment on attachment 390647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390647&action=review > Source/WebCore/html/track/DataCue.cpp:119 > + const SerializedPlatformDataCue* otherPlatformValue = dataCue->platformValue(); s/SerializedPlatformDataCue/auto/ > Source/WebCore/platform/SerializedPlatformDataCue.h:2 > + * Copyright (C) 2014 Apple Inc. All rights reserved. 2020? > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:38 > +class SerializedPlatformDataCueMac : public SerializedPlatformDataCue { final? > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:46 > + bool isEqual(const SerializedPlatformDataCue&) const override; final here and above? > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:53 > + SerializedPlatformDataCueMac(id nativeValue); explicit.
youenn fablet
Comment 5 2020-02-13 08:32:03 PST
Need to update cmake build probably
youenn fablet
Comment 6 2020-02-13 08:33:13 PST
Source/WebCore/Headers.cmake
Eric Carlson
Comment 7 2020-02-13 08:41:03 PST
Created attachment 390650 [details] Patch for landing
Eric Carlson
Comment 8 2020-02-13 08:46:35 PST
Created attachment 390652 [details] Patch for landing
WebKit Commit Bot
Comment 9 2020-02-13 13:40:13 PST
Comment on attachment 390652 [details] Patch for landing Clearing flags on attachment: 390652 Committed r256536: <https://trac.webkit.org/changeset/256536>
WebKit Commit Bot
Comment 10 2020-02-13 13:40:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.