Bug 207694

Summary: [WPE] Add support for rendering sliders for range elements
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-02-13 06:50:38 PST
.
Attachments
Patch (7.72 KB, patch)
2020-02-13 06:52 PST, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-02-13 06:52:26 PST
Created attachment 390637 [details] Patch
Adrian Perez
Comment 2 2020-02-20 00:04:23 PST
Comment on attachment 390637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390637&action=review > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:368 > + if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart) Wouldn't it be enought here to use an assertion instead of a conditional statement? e.g. ASSERT(part == SliderThumbHorizontalPart || part == SliderThumbVerticalPart)
Carlos Garcia Campos
Comment 3 2020-02-20 02:02:10 PST
Comment on attachment 390637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390637&action=review >> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:368 >> + if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart) > > Wouldn't it be enought here to use an assertion instead of a conditional > statement? e.g. > > ASSERT(part == SliderThumbHorizontalPart || part == SliderThumbVerticalPart) No, this can be called for other slider thumbs, like the media controls that we render differently. By not setting a size here for them we ensure RenderThemeWPE::paintSliderThumb() is not called fro them, that's why the assert is correct there.
Carlos Garcia Campos
Comment 4 2020-02-20 02:03:28 PST
Committed r257048: <https://trac.webkit.org/changeset/257048>
Note You need to log in before you can comment on or make changes to this bug.