Bug 207633

Summary: [LFC][IFC] Display::Run should not have any geometry mutation functions.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-cq-03 for mac-mojave none

Description zalan 2020-02-12 07:44:47 PST
All the geometry information is readily available at construction time.
Comment 1 Radar WebKit Bug Importer 2020-02-12 07:45:16 PST
<rdar://problem/59386235>
Comment 2 zalan 2020-02-12 07:53:30 PST
Created attachment 390522 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-12 09:38:46 PST
The commit-queue encountered the following flaky tests while processing attachment 390522 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-02-12 09:39:12 PST
The commit-queue encountered the following flaky tests while processing attachment 390522 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-02-12 10:30:10 PST
Comment on attachment 390522 [details]
Patch

Rejecting attachment 390522 [details] from commit-queue.

New failing tests:
editing/spelling/spellcheck-async-remove-frame.html
Full output: https://webkit-queues.webkit.org/results/13321450
Comment 6 WebKit Commit Bot 2020-02-12 10:30:13 PST
Created attachment 390534 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-mojave  Platform: Mac OS X 10.14.6
Comment 7 WebKit Commit Bot 2020-02-12 11:07:30 PST
Comment on attachment 390522 [details]
Patch

Clearing flags on attachment: 390522

Committed r256458: <https://trac.webkit.org/changeset/256458>
Comment 8 WebKit Commit Bot 2020-02-12 11:07:32 PST
All reviewed patches have been landed.  Closing bug.