Bug 20761

Summary:

Add a protected destructor for RefCounted

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Web Template Framework

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Trivial

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	eric: review+

Description Alexey Proskuryakov 2008-09-10 02:02:31 PDT

It is wrong to call its destructor directly, because (1) this should be taken care of by deref(), and (2) many classes that use RefCounted have non-virtual destructors.

Comment 1 Alexey Proskuryakov 2008-09-10 02:04:05 PDT

Created attachment 23315 [details]
proposed patch

Comment 2 Eric Seidel (no email) 2008-09-12 12:24:11 PDT

Comment on attachment 23315 [details]
proposed patch

r=me

Comment 3 Alexey Proskuryakov 2008-09-17 23:51:20 PDT

Committed <http://trac.webkit.org/projects/webkit/changeset/36425>.