Bug 20761

Summary: Add a protected destructor for RefCounted
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Web Template FrameworkAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Trivial    
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch eric: review+

Alexey Proskuryakov
Reported 2008-09-10 02:02:31 PDT
It is wrong to call its destructor directly, because (1) this should be taken care of by deref(), and (2) many classes that use RefCounted have non-virtual destructors.
Attachments
proposed patch (1.05 KB, patch)
2008-09-10 02:04 PDT, Alexey Proskuryakov 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-09-10 02:04:05 PDT
Created attachment 23315 [details] proposed patch
Eric Seidel (no email)
Comment 2 2008-09-12 12:24:11 PDT
Comment on attachment 23315 [details] proposed patch r=me
Alexey Proskuryakov
Comment 3 2008-09-17 23:51:20 PDT
Committed <http://trac.webkit.org/projects/webkit/changeset/36425>.
Note You need to log in before you can comment on or make changes to this bug.